Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Testing with CFN Lint Version & Command" job failing for windows-201{6,9} #141

Closed
ScottBrenner opened this issue Feb 1, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ScottBrenner
Copy link
Owner

Describe the bug
The "Testing with CFN Lint Version & Command" job recently began failing for both windows-2016 and windows-2019:

GitHub Actions Runner configuration (please complete the following information):

Additional context
https://stackoverflow.com/a/58959576 suggests updating Node?

@ScottBrenner ScottBrenner added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 1, 2022
@NickLiffen
Copy link
Collaborator

I think it could be to do with this:

https://github.com/ScottBrenner/cfn-lint-action/blob/main/lib/utils/helpers.js#L10

Maybe Win32 is no longer the right option 🤔

@NickLiffen
Copy link
Collaborator

@ScottBrenner we are running Node 12, maybe changing this to node16 could do it.

@ScottBrenner
Copy link
Owner Author

Attempted node16 in #152, no luck. win32 seems right from https://nodejs.org/api/os.html#os_os_platform

@NickLiffen
Copy link
Collaborator

I will try and get around to this Monday 👍

@ScottBrenner
Copy link
Owner Author

Seems to be passing now, odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants