Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): Replace windows-2016 with windows-2022 #151

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

ScottBrenner
Copy link
Owner

@ScottBrenner ScottBrenner commented Feb 18, 2022

Summary

actions/runner-images#4312

Windows Server 2016 Active support ends on 11 Jan 2022 and Windows Server 2022 VM image is going out of beta later this year

Semi-related to #141, maybe

@ScottBrenner ScottBrenner added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Feb 18, 2022
- windows-2019
- windows-2022
- macos-10.15
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- macos-10.15
- macos-10.15
- macos-11

Might as well, maybe separately - reference https://github.com/actions/virtual-environments#available-environments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed 👍 I thnk the same can go for Windows as well? :)

@ScottBrenner ScottBrenner enabled auto-merge (squash) March 7, 2022 16:52
@ScottBrenner ScottBrenner merged commit 1c27985 into main Mar 7, 2022
@ScottBrenner ScottBrenner deleted the ScottBrenner-patch-1 branch March 7, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants