Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GCS optional #1019

Merged
merged 8 commits into from
Nov 1, 2019
Merged

Make GCS optional #1019

merged 8 commits into from
Nov 1, 2019

Conversation

adriangonz
Copy link
Contributor

Fixes #1018.

Changelog

  • Import tests on Storage.py from KFserving.
  • Move google-cloud-storage to extras_require under the gcs key.
  • Rename tf_helper.py to imports_helper.py.
  • Add new all key to extras_require which will install all the optional dependencies.
  • Add CI tests for seldon_core[gcs] and seldon_core[all].

@adriangonz
Copy link
Contributor Author

/uncc @gipster @gsunner
/cc @jklaise @axsaucedo @cliveseldon

@axsaucedo
Copy link
Contributor

/ok-to-test

@axsaucedo
Copy link
Contributor

/test this

1 similar comment
@axsaucedo
Copy link
Contributor

/test this

@adriangonz
Copy link
Contributor Author

The linter will get fixed once #1020 is merged and this PR gets rebased.

@axsaucedo
Copy link
Contributor

/test lint

@axsaucedo
Copy link
Contributor

Just needs rebase, but looks good. I think having this as optional will not be as intuitive, so we'll have to make sure we are able to come up with a unified way to cover it through #885.

@axsaucedo
Copy link
Contributor

It seems that Azure released an update that pushed their version 2.x into 12.x which apparently is breaking due to the version being bigger. Might be worth adding this fix to this PR:
image

@axsaucedo
Copy link
Contributor

This is the bump in versions - crazy
image

@axsaucedo
Copy link
Contributor

This basically adds to the point we were discussing - maintaining a library that keeps in sync with all the changes across these cloud libraries may become increasingly complex. Really interesting with the timing!

@adriangonz
Copy link
Contributor Author

Fixes #1023

@axsaucedo
Copy link
Contributor

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration fb8612c link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor Author

/approve

@adriangonz
Copy link
Contributor Author

/lgtm

@seldondev
Copy link
Collaborator

@adriangonz: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz adriangonz merged commit 37c6022 into SeldonIO:master Nov 1, 2019
@adriangonz adriangonz deleted the remove-gcs branch November 1, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GCS support optional
3 participants