-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GCS optional #1019
Make GCS optional #1019
Conversation
/uncc @gipster @gsunner |
cbcfba6
to
60108bd
Compare
/ok-to-test |
/test this |
1 similar comment
/test this |
The linter will get fixed once #1020 is merged and this PR gets rebased. |
/test lint |
Just needs rebase, but looks good. I think having this as optional will not be as intuitive, so we'll have to make sure we are able to come up with a unified way to cover it through #885. |
This basically adds to the point we were discussing - maintaining a library that keeps in sync with all the changes across these cloud libraries may become increasingly complex. Really interesting with the timing! |
f14ccef
to
a3b7f90
Compare
Fixes #1023 |
/test integration |
1 similar comment
/test integration |
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
/lgtm |
@adriangonz: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1018.
Changelog
Storage.py
from KFserving.google-cloud-storage
toextras_require
under thegcs
key.tf_helper.py
toimports_helper.py
.all
key toextras_require
which will install all the optional dependencies.seldon_core[gcs]
andseldon_core[all]
.