-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle http status code error #1117
Conversation
Hi @lennon310. Thanks for your PR. I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
engine/src/main/java/io/seldon/engine/service/InternalPredictionService.java
Show resolved
Hide resolved
/test integration |
@lennon310 thanks for your contribution! I think that if we add a couple of tests to ensure that non-200 responses are now handled properly, this PR should be good to go. |
All integration tests seem to pass as well, so totally agree with @adriangonz ! |
Thanks very much for @adriangonz 's help to fix the unit test! |
/approve Looks good to me! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Trying to address this issue.
I assume the
HttpStatusCodeException
is thrown frompostForEntity
method if the response if non-200.