Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle http status code error #1117

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

lennon310
Copy link
Contributor

Trying to address this issue.

I assume the HttpStatusCodeException is thrown from postForEntity method if the response if non-200.

@seldondev
Copy link
Collaborator

Hi @lennon310. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test

@axsaucedo
Copy link
Contributor

/test integration

@adriangonz
Copy link
Contributor

@lennon310 thanks for your contribution!

I think that if we add a couple of tests to ensure that non-200 responses are now handled properly, this PR should be good to go.

@axsaucedo
Copy link
Contributor

All integration tests seem to pass as well, so totally agree with @adriangonz !

@seldondev seldondev added size/L and removed size/M labels Nov 20, 2019
@lennon310
Copy link
Contributor Author

Thanks very much for @adriangonz 's help to fix the unit test!

@adriangonz
Copy link
Contributor

/approve

Looks good to me!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants