Add integration test to verify non200 response handling

[lennon310]

Integration tests on this PR.

[seldondev]

Hi @lennon310. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[axsaucedo]

/ok-to-test
/cc @adriangonz

[axsaucedo]

@lennon310 just as a heads up, you can see all the logs in the gh-pages branch of the seldon-core repo. Here are the logs for this one https://github.com/SeldonIO/seldon-core/tree/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1132

We have some known issues with KIND clusters which is tracked on their repo. In this case, your test actually passes - the one that failed was due to this KIND cluster, so we can land now.

[axsaucedo]

Oh actually, I'm just having a look at the logs and it seems that it's specifically your test that failed. It may be due to the hash not being the correct one as it can't seem to find it.

[axsaucedo]

@lennon310 if you run only that test locally does it build and deploy the image correctly?

[lennon310]

/test integration

[lennon310]

@axsaucedo Integrations test seems to pass now.

[axsaucedo]

Great! Thank you for the contribution @lennon310!
/approve
/lgtm

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment