Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve integration tests stability #2409

Merged
merged 1 commit into from
Sep 10, 2020
Merged

improve integration tests stability #2409

merged 1 commit into from
Sep 10, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Recently TestPrepack.test_text_alibi_explainer was failing a lot in the integration tests.
This PR is fixing it.

Which issue(s) this PR fixes:

Fixes #2408

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@RafalSkolasinski
Copy link
Contributor Author

/test ingeration

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 10 13:01:28 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2409/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2409 --build=1

@seldondev
Copy link
Collaborator

Thu Sep 10 13:01:38 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2409/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2409 --build=2

@seldondev
Copy link
Collaborator

Thu Sep 10 13:02:19 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2409/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2409 --build=3

@axsaucedo
Copy link
Contributor

As discussed on slack, good to go
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 4eda2e5 into SeldonIO:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration tests flakiness with TestPrepack.test_text_alibi_explainer
3 participants