Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve integration tests stability #2409

Merged
merged 1 commit into from
Sep 10, 2020
Merged

improve integration tests stability #2409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions testing/scripts/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,22 @@ helm_setup:
helm repo update

install_ambassador:
helm install ambassador \
helm upgrade ambassador \
datawire/ambassador \
-f ../resources/ambassador_values.yaml \
--set image.repository=quay.io/datawire/ambassador \
--set crds.keep=false \
--set enableAES=false \
--namespace seldon \
--set replicaCount=1 \
--wait
--wait --install

install_jaeger:
helm install jaeger-operator \
helm upgrade jaeger-operator \
jaegertracing/jaeger-operator \
--set rbac.clusterRole=true \
--namespace seldon \
--wait
--wait --install
kubectl apply -f ../resources/jaeger.yaml --namespace seldon


Expand All @@ -74,14 +74,14 @@ install_cert_manager:
install_seldon: install_cert_manager
kubectl create namespace seldon-system || echo "namespace seldon-system exists"
helm delete seldon --namespace seldon-system || echo "seldon-core not installed"
helm install seldon \
helm upgrade seldon \
../../helm-charts/seldon-core-operator \
--namespace seldon-system \
--set istio.enabled=true \
--set istio.gateway=istio-system/seldon-gateway \
--set certManager.enabled=false \
--set executor.enabled=$(SELDON_E2E_TESTS_USE_EXECUTOR) \
--wait
--wait --install

install_istio:
kubectl apply -f istio-1.4.2.yaml
Expand Down
2 changes: 2 additions & 0 deletions testing/scripts/seldon_e2e_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def initial_rest_request(
dtype="tensor",
names=None,
method="predict",
predictor_name="default",
):
sleeping_times = [1, 5, 10]
attempt = 0
Expand All @@ -244,6 +245,7 @@ def initial_rest_request(
dtype=dtype,
names=names,
method=method,
predictor_name=predictor_name,
)

if r is None or r.status_code != 200:
Expand Down
2 changes: 1 addition & 1 deletion testing/scripts/test_prepackaged_servers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def test_text_alibi_explainer(self, namespace):
"movie", namespace, data=["This is test data"], dtype="ndarray"
)
assert r.status_code == 200
e = rest_request(
e = initial_rest_request(
"movie",
namespace,
data=["This is test data"],
Expand Down