fix(ci): Changes from v2 for release 2.8.4 (2) #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…status (#5945) Before this change, the Server StatefulSet was marked as ready when `StatefulSet.Status.ReadyReplicas` equals `StatefulSet.Status.Replicas`. However, this doesn't account for the possibility of `StatefulSet.Spec.Replicas` to differ from `StatefulSet.Status.Replicas` for a long time (desired state vs actual state). The change corrects this so that we only mark the StatefulSet as ready when the number of ready replicas matches the desired state.
In #5889, we've missed updating the agent for triton in the published components.yaml Running `make create` in `[seldon-core]/k8s/` has surfaced the diff.
* feat: adding -ldflag and -trimpath to go build * fix: review comments to not to add -s flag * fix: review comment and -s flag
**PR Summary: New Documentation Site for Seldon Core v2 (#5760)** This PR introduces a comprehensive update to the documentation site for Seldon Core v2, aligning the format with GitBook requirements. Key changes include: - **File and Directory Restructuring**: Moved and renamed multiple files and directories to match GitBook's expected format, including APIs, models, examples, CLI, Kubernetes, and performance tests sections. - **Content Updates**: - Completed the APIs section and Getting Started guide. - Enhanced and reorganized the models directory and various other docs. - Outliers, drift, servers, pipelines, inference, explainers, and experiments docs moved to the root directory with improvements. - New documentation for HPA-based autoscaling for scaling both Models and Servers, referencing Model RPS metrics from Prometheus. - Added per-component labels and annotations in documentation. - **Images**: Consolidated images into a dedicated directory and updated links throughout the docs. - **Format Fixes**: Resolved broken links, corrected typos, and fixed references in Kubernetes and other sections. - **GitBook-Specific Updates**: - Updated `SUMMARY.md` for GitBook compatibility. - Reformatted the development, metrics, and K8s directories for GitBook’s markdown flavor. - Added GitHub Gist references for certain files (replacing hard-coded references). Co-authored by multiple contributors from the Seldon Core team. @Rajakavitha1 and @lc525
* update kind/k8s to 1.31 * change k8s version in playbook
The new, gitbook-based docs already had the right formula
* feat(docs): improve HPA autoscaling docs - fix formatting for reading outside gitbook - add details on custom metrics of type `Object` Co-authored-by: Rajakavitha Kodhandapani <[email protected]>
… scheduler disconnect. (#5944) * move initial sync to scheduler to a separate logic (servers) * add coverage for model statues * add control plane rpc (scheduler<->controller) * add control plane stream code and test * add stop control plane stream * add control plane client handling * add handle state reconstruction to the control plane * adjust name of the logger func * block streams connecting until scheduler is ready * adjust simple schedule code * adjust simple sync (2) * add exec with timeout for the control plane ops (for state) * do not block Load/Unload models on scheduling * add test for subscribe control plane stream * extend control plane tests * fix lint * PR comments
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sakoush
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to fix some issues exposed in testing the previous rc.