v2.6 #640

aliparlakci · 2022-07-05T10:05:34Z

No description provided.

…exible OAuth connection.

Clarify that fact that downloading by user doesn't work the same way as downloading by subreddit. Feel free to user a better example username. :)

If this doesn't work then I give up...

Cover edge cases that shouldn't ever happen but probably will sometime. Also included Imgur changes to cover similar situations of malformed/redirected links.

This reverts commit 2f2b5b7.

Cover edge cases that shouldn't ever happen but probably will sometime.

Update Imgur logic to cover malformed links that cause a redirect leading to the html of the page being saved as an image.

Soulsuck24 · 2022-09-21T16:26:20Z

Is there any testing or anything in particular that needs to be done for this to get merged and put out as a new version? Can try to help if there is, just not sure as it's been here a while now and with the api changes at Redgifs it's probably best to get this out to the main branch sooner rather than later.

Serene-Arc · 2022-09-22T00:40:49Z

There's a requirement that all of the tests pass before the changes are pushed. I have to go through and troubleshoot the failing tests. For the site downloader modules, I have to see which resources are failing, investigate why they're failing, decide whether to remove them, and then find replacement test cases if they are removed.

The last one involves a fair bit of porn so I'm not raring to to go with that, but I'll get to them. If you want to take a crack at some of them, go ahead. Just please open a PR for each test module you change and try not to narrow the scope of the tests. Like if the test case is for a page with multiple image files, find a replacement with multiple image files.

I'm going to try to get a few of the tests fixed today but it's a process.

Update broken ID's in clone integration test

Update broken ID's in download integration test

Update user that was banned/suspended with one that should not end up that way.

The old change twice forget once. Forgot I changed it back to a SelfPost rather than Direct.

OMEGARAZER · 2022-09-26T22:16:10Z

So I took the changes from #668 and tested everything on my local instance and all the tests seem to have passed but there's 3 that were skipped in test_connector. I've tried to figure it out but as I'm not too familiar with pytest I'm not too sure what needs to be changed to fix it so they're not skipped.

============================================================================================================ test session starts ============================================================================================================
platform linux -- Python 3.10.6, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/x/bulk-downloader-for-reddit, configfile: pytest.ini
collected 449 items

tests/test_archiver.py ...                                                                                                                                                                                                            [  0%]
tests/test_configuration.py ...                                                                                                                                                                                                       [  1%]
tests/test_connector.py ................................................sss..............................                                                                                                                             [ 19%]
tests/test_download_filter.py ...................                                                                                                                                                                                     [ 23%]
tests/test_downloader.py ...............                                                                                                                                                                                              [ 26%]
tests/test_file_name_formatter.py ......................................................................................                                                                                                              [ 46%]
tests/test_oauth2.py ............                                                                                                                                                                                                     [ 48%]
tests/test_resource.py ...........                                                                                                                                                                                                    [ 51%]
tests/archive_entry/test_comment_archive_entry.py ....                                                                                                                                                                                [ 52%]
tests/archive_entry/test_submission_archive_entry.py ..                                                                                                                                                                               [ 52%]
tests/integration_tests/test_archive_integration.py .................                                                                                                                                                                 [ 56%]
tests/integration_tests/test_clone_integration.py ....                                                                                                                                                                                [ 57%]

tests/integration_tests/test_download_integration.py .................................................................                                                                                                                [ 71%]
tests/site_downloaders/test_direct.py ..                                                                                                                                                                                              [ 72%]
tests/site_downloaders/test_download_factory.py ...........................................                                                                                                                                           [ 81%]
tests/site_downloaders/test_erome.py ....                                                                                                                                                                                             [ 82%]
tests/site_downloaders/test_gallery.py ........                                                                                                                                                                                       [ 84%]
tests/site_downloaders/test_gfycat.py ....                                                                                                                                                                                            [ 85%]
tests/site_downloaders/test_imgur.py ..........................                                                                                                                                                                       [ 91%]
tests/site_downloaders/test_pornhub.py .                                                                                                                                                                                              [ 91%]
tests/site_downloaders/test_redgifs.py ...........                                                                                                                                                                                    [ 93%]
tests/site_downloaders/test_self_post.py ...                                                                                                                                                                                          [ 94%]
tests/site_downloaders/test_vidble.py ..........                                                                                                                                                                                      [ 96%]
tests/site_downloaders/test_vreddit.py ..                                                                                                                                                                                             [ 97%]
tests/site_downloaders/test_youtube.py ...                                                                                                                                                                                            [ 97%]
tests/site_downloaders/fallback_downloaders/test_ytdlp_fallback.py ..........                                                                                                                                                         [100%]

============================================================================================================= warnings summary ==============================================================================================================
tests/test_connector.py::test_get_multireddits_public[helen_darten-test_multireddits0-10]
tests/test_connector.py::test_get_multireddits_public[korfor-test_multireddits1-100]
  /home/x/bulk-downloader-for-reddit/tests/test_connector.py:289: DeprecationWarning: Positional arguments for 'MultiredditHelper.__call__' will no longer be supported in PRAW 8.
  Call this function with 'redditor' and 'name' as keyword arguments.
    reddit_instance.multireddit(test_user, test_multireddits[0]),

tests/test_connector.py::test_get_multireddits_public[helen_darten-test_multireddits0-10]
tests/test_connector.py::test_get_multireddits_public[korfor-test_multireddits1-100]
tests/integration_tests/test_download_integration.py::test_cli_download_multireddit[test_args0]
tests/integration_tests/test_download_integration.py::test_cli_download_multireddit[test_args1]
tests/integration_tests/test_download_integration.py::test_cli_download_multireddit[test_args2]
tests/integration_tests/test_download_integration.py::test_cli_download_multireddit[test_args3]
tests/integration_tests/test_download_integration.py::test_cli_download_multireddit_nonexistent[test_args0]
  /home/x/bulk-downloader-for-reddit/bdfr/connector.py:326: DeprecationWarning: Positional arguments for 'MultiredditHelper.__call__' will no longer be supported in PRAW 8.
  Call this function with 'redditor' and 'name' as keyword arguments.
    multi = self.reddit_instance.multireddit(self.args.user[0], multi)

tests/archive_entry/test_comment_archive_entry.py: 148 warnings
tests/archive_entry/test_submission_archive_entry.py: 102 warnings
tests/integration_tests/test_archive_integration.py: 30979 warnings
tests/integration_tests/test_clone_integration.py: 1102 warnings
  /home/x/bulk-downloader-for-reddit/bdfr/archive_entry/base_archive_entry.py:35: DeprecationWarning: Positional arguments for 'CommentForest.replace_more' will no longer be supported in PRAW 8.
  Call this function with 'limit' as a keyword argument.
    in_comment.replies.replace_more(0)

tests/archive_entry/test_submission_archive_entry.py: 1 warning
tests/integration_tests/test_archive_integration.py: 354 warnings
tests/integration_tests/test_clone_integration.py: 4 warnings
  /home/x/bulk-downloader-for-reddit/bdfr/archive_entry/submission_archive_entry.py:48: DeprecationWarning: Positional arguments for 'CommentForest.replace_more' will no longer be supported in PRAW 8.
  Call this function with 'limit' as a keyword argument.
    self.source.comments.replace_more(0)

tests/integration_tests/test_archive_integration.py::test_cli_archive_all_user_comments[test_args0]
tests/integration_tests/test_archive_integration.py::test_cli_archive_all_user_comments[test_args1]
tests/integration_tests/test_download_integration.py::test_cli_download_search_subreddits_authenticated[test_args0]
tests/integration_tests/test_download_integration.py::test_cli_download_search_subreddits_authenticated[test_args1]
tests/integration_tests/test_download_integration.py::test_cli_download_user_specific_subreddits[test_args0]
tests/integration_tests/test_download_integration.py::test_cli_download_user_data_good[test_args1]
tests/integration_tests/test_download_integration.py::test_cli_download_user_data_good[test_args2]
tests/integration_tests/test_download_integration.py::test_cli_download_user_data_good[test_args3]
  /home/x/.local/lib/python3.10/site-packages/praw/reddit.py:583: DeprecationWarning: Token managers have been deprecated and will be removed in the near future. See https://www.reddit.com/r/redditdev/comments/olk5e6/followup_oauth2_api_changes_regarding_refresh/ for more details.
    self._prepare_common_authorizer(authenticator)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================================== 446 passed, 3 skipped, 32707 warnings in 4977.89s (1:22:57) ========================================================================================```

Serene-Arc · 2022-09-27T01:00:01Z

Fixed the issue of the skipped tests, was an old path issue.

BlipRanger and others added 30 commits May 12, 2021 10:18

Bind socket to '0.0.0.0' rather than 'localhost' to allow for more fl…

99fe331

…exible OAuth connection.

Merge branch 'aliparlakci:master' into master

4fd903c

Add PowerShell scripts

850faff

Fix wrong offset

ac3a8e9

Fix Bash script: Failed to write

8ec45a9

Fix offset and remove substring

3811ec3

Merge pull request #581 from Thayol/fix-bash-script-failed-id

49d1626

Merge pull request #579 from Thayol/add-powershell-scripts

57b3bb3

Add --subscribed option

0177b43

Merge pull request #600 from Serene-Arc/enhancement_574

85b2165

Add support for Redgifs images and galleries

9deef63

Merge pull request #601 from Serene-Arc/bug_fix_598

5adb9f9

Add file scheme naming for archiver

6e0c642

Merge pull request #602 from Serene-Arc/bug_fix_531

6b7e551

Increase version number

71f8442

Fix gfycat after redgifs changes

7645319

Update test hashes

160ee37

Switch redgifs to dynamic file extensions

06988c4

Merge pull request #606 from Serene-Arc/bug_fix_605

5f779c7

Update Readme with some command clarifications

81b7fe8

Clarify that fact that downloading by user doesn't work the same way as downloading by subreddit. Feel free to user a better example username. :)

Merge pull request #619 from sinclairkosh/patch-1

a2aa739

Strip any newline characters from names

806bd76

Add second test case

5a3ff88

Merge pull request #621 from Serene-Arc/bug_fix_616

2c93537

Use stdout

b921d03

readme: make --search info a bit more clear

68e3674

Merge pull request #628 from chapmanjacobd/patch-2

90b6809

okay

4e050c5

oh there's another one

484bde9

and this one too

5775c0a

Soulsuck24 and others added 12 commits September 16, 2022 20:41

Redgifs fixed?

9574958

If this doesn't work then I give up...

Edge case coverage

2f2b5b7

Cover edge cases that shouldn't ever happen but probably will sometime. Also included Imgur changes to cover similar situations of malformed/redirected links.

Revert "Edge case coverage"

d4f7dea

This reverts commit 2f2b5b7.

Redo edge case coverage for Redgifs

7bd957a

Cover edge cases that shouldn't ever happen but probably will sometime.

Imgur updates

106d759

Update Imgur logic to cover malformed links that cause a redirect leading to the html of the page being saved as an image.

Fix Redgifs tests

5c343ef

Add dev requirements file

c4a9da0

Merge pull request #659 from Soulsuck24/development

f4598c4

Merge branch 'development' into imgur

0681609

Remove duplicate entries

1dff750

Fix tests

cd05bc3

Merge pull request #664 from Soulsuck24/imgur

398f7b2

OMEGARAZER added 3 commits September 23, 2022 02:51

Update test_clone_integration.py

7fef6c4

Update broken ID's in clone integration test

Update test_download_integration.py

3906386

Update broken ID's in download integration test

Update test_connector.py

9c067ad

Update user that was banned/suspended with one that should not end up that way.

OMEGARAZER mentioned this pull request Sep 23, 2022

Fixing some test conditions #667

Merged

OMEGARAZER and others added 6 commits September 23, 2022 10:00

Update test_download_integration.py

ca33dee

The old change twice forget once. Forgot I changed it back to a SelfPost rather than Direct.

Merge pull request #667 from OMEGARAZER/development

e57932a

Update Erome link regex

57e59db

Remove obsolete test

7bb2a9a

Update hash

c834314

Update hashes

3b5f8bc

Serene-Arc added 3 commits September 27, 2022 10:52

Update yt-dlp requirement version

d4664d7

Update test

b7d2116

Update path so tests do not skip

0ce2585

Serene-Arc merged commit e7629d7 into master Sep 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.6 #640

v2.6 #640

aliparlakci commented Jul 5, 2022

Soulsuck24 commented Sep 21, 2022 •

edited

Loading

Serene-Arc commented Sep 22, 2022

OMEGARAZER commented Sep 26, 2022

Serene-Arc commented Sep 27, 2022

v2.6 #640

v2.6 #640

Conversation

aliparlakci commented Jul 5, 2022

Soulsuck24 commented Sep 21, 2022 • edited Loading

Serene-Arc commented Sep 22, 2022

OMEGARAZER commented Sep 26, 2022

Serene-Arc commented Sep 27, 2022

Soulsuck24 commented Sep 21, 2022 •

edited

Loading