Fix Vidble/Erome tests #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes broken link in Vidble test. these watch?= seem short lived, not common and tricky to track down, may need to consider removing it from future tests.
Bashed my head on this for a few days before realizing I overlooked that they seem to have changed from s to v. Left s as an optional incase it's not permanent or in flux.
|
Also managed to figure out what was happening with the Erome tests. If I'm not mistaken that's all the primarily "Adult" downloaders taken care of for you @Serene-Arc |
Merged
|
This one is out of date too. I've updated the regex in the Erome class already and the Vidble test case has been removed due to the source being deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken link in Vidble test.
these watch?= seem short lived, not common and tricky to track down, may need to consider removing it from future tests. In two days I've needed to change the link to test 4 times as they disappear. Hopefully this one hangs around long enough to work though.