Make sure the run cursor is saved in the job #1036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job starts without a cursor (i.e. after a run is resumed), but the run has a cursor, we do use the cursor from the run in
build_enumerator
.However, we don't store the cursor on the job itself at this point. If the first iteration fails, we go through the
on_error
callback and store the job cursor, which isnil
, on the run, effectively losing the progress previously made on the run.This fixes this issue by always storing the cursor on the job in
build_enumerator
, making sure the job and run have the same cursor.Fixes #1033