Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the run cursor is saved in the job #1036

Merged
merged 1 commit into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. Make sure the run cursor is saved in the job

    If a job starts without a cursor (i.e. after a run is resumed), but the
    run has a cursor, we do use the cursor from the run in build_enumerator.
    
    However, we don't store the cursor on the job itself at this point. If
    the first iteration fails, we go through the `on_error` callback and
    store the job cursor, which is `nil`, on the run, effectively losing the
    progress previously made on the run.
    
    This fixes this issue by always storing the cursor on the job in
    `build_enumerator`, making sure the job and run have the same cursor.
    etiennebarrie committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d298f37 View commit details
    Browse the repository at this point in the history