Relax strictness of annotation RBI files #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Changes
I changed all the annotation files to
typed: true
since anything above that is useless for annotation RBI files for two reasons:Class
withT::Class[T.anything]
in lhm-shopify RBI #168typed: strict
or above. That means that we hadn't been enforcing signatures to exist until now anyway.So the changes I've made can be read commit by commit and are:
typed: true
and force it to be so for all RBI files via therubocop
check.Sorbet/EnforceSignatures
cop to error for any methods that don't have signatures