Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax strictness of annotation RBI files #171

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Relax strictness of annotation RBI files #171

merged 5 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. Make all annotation files typed: true 

    Annotation RBI files don't have any need to be `typed: strict` or above, since there is nothing the end user can do to fix any strictness related errors anyway.

Moreover, as things stand right now, Sorbet does not generate static type-checking errors for missing `sig`s in files `typed: strict` or above, so there is no benefit to having them be at that strictness level.
    @paracycle
    paracycle committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cb832e2 View commit details
    Browse the repository at this point in the history

  2. Enforce sigils to be typed: true with RuboCop

    @paracycle
    paracycle committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    017090b View commit details
    Browse the repository at this point in the history

  3. Start showing errors for methods missing signatures 

    Use `Sorbet/EnforceSignatures` cop to check for missing signatures.
    @paracycle
    paracycle committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    348fc13 View commit details
    Browse the repository at this point in the history

  4. Add signatures to methods missing signatures

    @paracycle
    paracycle committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    99f706f View commit details
    Browse the repository at this point in the history

  5. Remove missing method

    @paracycle
    paracycle committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4983645 View commit details
    Browse the repository at this point in the history