starts_with? and ends_with?
#190
Conversation
amomchilov
force-pushed
the
amomchilov-patch-1
branch
from
31a14f1
to
5808095
Compare
| @@ -259,3 +259,23 @@ class Time | |||
| sig { returns(TrueClass) } | |||
| def present?; end | |||
| end | |||
|
|
|||
| class Symbol | |||
| # @shim: alias for `#start_with?` | |||
There was a problem hiding this comment.
Does it really need to be marked as @shim?
require "active_support"
Symbol.instance_method(:starts_with?) # => #<UnboundMethod: Symbol#starts_with?(start_with?)(*)>There was a problem hiding this comment.
TBH I don't even know what @shim does, I just cargo-culted it from the other sig 😅
Got any docs on it? Couldn't find any.
There was a problem hiding this comment.
To avoid errors and outdated RBIs, rbi-central CI will check that the method actually exist at runtime.
@shim is used to disable this check when the method doesn't actually exist and the RBI definition is used to shim the actual behavior to make typing possible: https://github.com/Shopify/rbi-central?tab=readme-ov-file#runtime-checks
In your case, I don't think you need it since the definition actually exists.
There was a problem hiding this comment.
Oh neat, thanks for pointing me to that!
Removed in #208
Type of Change
Changes
Tapioca v0.11.12Sorbet typechecker 0.5.11142