Remove unneeded @shim tags
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
amomchilov-patch-2
branch
from
15eb97a
to
c22b0e0
Compare
amomchilov
commented
Jan 2, 2024
index.json
Outdated
Comment on lines
39
to
40
| "active_support", | ||
| "active_support/core_ext/array", | ||
| "active_support/core_ext/string/starts_ends_with.rb", | ||
| "active_support/core_ext/symbol/starts_ends_with.rb", | ||
| "active_support/test_case" |
There was a problem hiding this comment.
Should we just do this instead?
Suggested change
| "active_support", | |
| "active_support/core_ext/array", | |
| "active_support/core_ext/string/starts_ends_with.rb", | |
| "active_support/core_ext/symbol/starts_ends_with.rb", | |
| "active_support/test_case" | |
| "active_support/all" |
amomchilov
added
documentation
Morriar
approved these changes
Jan 4, 2024
index.json
Outdated
Comment on lines
39
to
40
| "active_support", | ||
| "active_support/core_ext/array", | ||
| "active_support/core_ext/string/starts_ends_with.rb", | ||
| "active_support/core_ext/symbol/starts_ends_with.rb", | ||
| "active_support/test_case" |
amomchilov
force-pushed
the
amomchilov-patch-2
branch
from
c22b0e0
to
391bae7
Compare
Morriar
reviewed
Jan 4, 2024
index.json
Outdated
| "active_support", | ||
| "active_support/core_ext/array", | ||
| "active_support/test_case" | ||
| "active_support/all" |
There was a problem hiding this comment.
I think we still need active_support/test_case
There was a problem hiding this comment.
all really means all_but_not_testcase :D
amomchilov
force-pushed
the
amomchilov-patch-2
branch
from
391bae7
to
ef32a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
https://github.com/Shopify/rbi-central/pull/190/files#r1430544830
Changes
Tapioca v0.11.12Sorbet typechecker 0.5.11142