Make only a part of stop() method a critical section. (elastic#49756)

SivagurunathanV · Jan 21, 2020 · 4a126ab · 4a126ab
1 parent 617a9ce
commit 4a126ab
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/...l/src/main/java/org/elasticsearch/xpack/ml/dataframe/process/AnalyticsProcessManager.java b/...l/src/main/java/org/elasticsearch/xpack/ml/dataframe/process/AnalyticsProcessManager.java
@@ -93,7 +93,7 @@ public void runJob(DataFrameAnalyticsTask task, DataFrameAnalyticsConfig config,
                        Consumer<Exception> finishHandler) {
         executorServiceForJob.execute(() -> {
             ProcessContext processContext = new ProcessContext(config.getId());
-            synchronized (this) {
+            synchronized (processContextByAllocation) {
                 if (task.isStopping()) {
                     // The task was requested to stop before we created the process context
                     finishHandler.accept(null);
@@ -295,14 +295,17 @@ private void closeProcess(DataFrameAnalyticsTask task) {
             processContext.process.close();
             LOGGER.info("[{}] Closed process", configId);
         } catch (Exception e) {
-            String errorMsg = new ParameterizedMessage("[{}] Error closing data frame analyzer process [{}]"
-                , configId, e.getMessage()).getFormattedMessage();
+            String errorMsg = new ParameterizedMessage(
+                "[{}] Error closing data frame analyzer process [{}]", configId, e.getMessage()).getFormattedMessage();
             processContext.setFailureReason(errorMsg);
         }
     }
 
-    public synchronized void stop(DataFrameAnalyticsTask task) {
-        ProcessContext processContext = processContextByAllocation.get(task.getAllocationId());
+    public void stop(DataFrameAnalyticsTask task) {
+        ProcessContext processContext;
+        synchronized (processContextByAllocation) {
+            processContext = processContextByAllocation.get(task.getAllocationId());
+        }
         if (processContext != null) {
             LOGGER.debug("[{}] Stopping process", task.getParams().getId());
             processContext.stop();