Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make only a part of stop() method a critical section. #49756

Merged

Conversation

przemekwitek
Copy link
Contributor

PR #49282 made the AnalyticsProcessManager.stop method synchronized to prevent swallowing stop signal.
This PR relaxes the synchronization a bit aiming at:

  1. Keeping the guarantee that stop signal will not be swallowed (i.e. if stop is called soon after start, the start action will not execute)
  2. fixing a possible deadlock (which may be manifesting as timeout on CI)

Relates #49680

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants