Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Decrease" to the Change Effect. #5595

Closed
1 task done
JakeGBLP opened this issue Apr 10, 2023 · 2 comments
Closed
1 task done

Add "Decrease" to the Change Effect. #5595

JakeGBLP opened this issue Apr 10, 2023 · 2 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@JakeGBLP
Copy link

Suggestion

The 7th pattern of the change effect should include "decrease" along with "reduce"

Why?

The 7th pattern of the change effect is reduce %objects% by %objects%, it would be logical to add "decrease" to it as "decrease" and "reduce" stand for the same thing, as such (reduce|decrease) %objects% by %objects% should be the new pattern, no behavior changes.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 10, 2023
@TheLimeGlass TheLimeGlass added the priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). label Apr 11, 2023
@APickledWalrus APickledWalrus added the good first issue An issue that would be good for a first-time contributor to make a PR for label May 16, 2023
@APickledWalrus
Copy link
Member

"Good First Issue" Tutorial:

This change is very easy. Simply change the line at

Skript/src/main/java/ch/njol/skript/effects/EffChange.java

Line 90 in 6724b01

{"reduce %~objects% by %objects%", ChangeMode.REMOVE},
to include a choice pattern for both reduce and decrease. This would appear as (reduce|decrease) (the user can then make use of either word).

@JakeGBLP
Copy link
Author

"Good First Issue" Tutorial:

This change is very easy. Simply change the line at

Skript/src/main/java/ch/njol/skript/effects/EffChange.java

Line 90 in 6724b01

{"reduce %~objects% by %objects%", ChangeMode.REMOVE},

to include a choice pattern for both reduce and decrease. This would appear as (reduce|decrease) (the user can then make use of either word).

real

Fusezion added a commit to Fusezion/Skript-forky that referenced this issue Sep 7, 2023
@Fusezion
Add decrease to EffChange
a7b5843 
Ref SkriptLang#5595
This was referenced Sep 7, 2023
Closed
Merged
@sovdeeth sovdeeth added the PR available Issues which have a yet-to-be merged PR resolving it label Sep 7, 2023
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sovdeeth @TheLimeGlass @AyhamAl-Ali @APickledWalrus @JakeGBLP