Add decrease to EffChange #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
AyhamAl-Ali
approved these changes
Sep 7, 2023
|
This is a game-changing pull, I think we should reread it before we do anything, We need to make sure we understand the implications of what we're doing. |
|
I would say it must be followed by at least 5 JUnit tests and goes under our Skript test discord server. |
Moderocky
approved these changes
Sep 7, 2023
TheLimeGlass
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
decreasetoreducechangerignore that issue's close pull request, I did it for wrong branch
Target Minecraft Versions: 'any'
Requirements: 'none'
Related Issues: #5595