Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.13 Particles and Potion Effects #1606

Merged
merged 3 commits into from
Oct 16, 2018
Merged

1.13 Particles and Potion Effects #1606

merged 3 commits into from
Oct 16, 2018

Conversation

ShaneBeee
Copy link
Contributor

Target Minecraft versions: 1.13.x
Requirements: none
Related issues: #1385

Description:
Added in the new particles and potion/status effects from 1.13.x

@Nicofisi Nicofisi added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 16, 2018
TheBentoBox
TheBentoBox approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@TheBentoBox TheBentoBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Verified the enum names, and the English namings seem good to me.

@Nicofisi
Copy link
Member

Big thanks to both of you! <3

@Nicofisi Nicofisi merged commit f2d8e7d into SkriptLang:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBentoBox TheBentoBox TheBentoBox approved these changes

@bensku bensku Awaiting requested review from bensku

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaneBeee @Nicofisi @bensku @TheBentoBox