Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features from 1.13 #1385

Open
52 of 59 tasks
Nicofisi opened this issue Jul 17, 2018 · 13 comments
Open
52 of 59 tasks

New features from 1.13 #1385

Nicofisi opened this issue Jul 17, 2018 · 13 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Nicofisi
Copy link
Member

Nicofisi commented Jul 17, 2018

I tried to list all the new features in 1.13 that are relevant for Skript

Many new items/blocks

Out of scope of the issue, need to be taken care of in skript-aliases (useful link - here)

New biomes

  • minecraft:small_end_islands
  • minecraft:end_midlands
  • minecraft:end_highlands
  • minecraft:end_barrens
  • minecraft:warm_ocean
  • minecraft:lukewarm_ocean
  • minecraft:cold_ocean
  • minecraft:deep_warm_ocean
  • minecraft:deep_lukewarm_ocean
  • minecraft:deep_cold_ocean
  • minecraft:deep_frozen_ocean
  • minecraft:frozen_ocean

New enchantments

  • Channeling
  • Impaling
  • Loyalty
  • Riptide

New particles

  • minecraft:bubble_column_up
  • minecraft:bubble_pop
  • minecraft:current_down
  • minecraft:squid_ink
  • minecraft:dolphin
  • minecraft:nautlius

New status effects

  • Conduit Power
  • Dolphin's Grace
  • Slow Falling

New entities

  • Dolphin
  • Drowned
  • Phantom
  • Cod
  • PufferFish
  • Salmon
  • TropicalFish
  • Turtle
  • Trident

Tags

  • Some support for checking whether something is tagged with some tag could be added, not sure about modifying them though - related link

New things in the Bukkit API

Added after 1.12

  • Entity.getPistonMoveReaction()
  • BroadcastMessageEvent extends ServerEvent implements Cancellable
  • PlayerPickupItemEvent (which Skript uses) deprecated in favor of the new EntityPickupItemEvent (we should probably support both?)

Added after 1.12.2

  • Creeper
    • getMaxFuseTicks()I, setMaxFuseTicks(I)
    • getExplosionRadius()I, setExplosionRadius(I)
  • Score#isScoreSet()Z although Skript has no scoreboard support at the moment
  • PlayerItemMendEvent extends PlayerEvent implements Cancellable
    • getPlayer()Player
    • getItem()ItemStack
    • getExperienceOrb()ExperienceOrb
    • getRepairAmount()I, setRepairAmount(I)
  • Player#hidePlayer and Player.showPlayer were interestingly improved - handled by @Blueyescat
  • Villager
    • getCareer()Career, setCareer(Career)
    • setCareer(Career, boolean resetTrades) - more info
  • New methods in CreatureSpawner but Skript doesn't have any spawner support afaik
  • AbstractHorse#getInventory()AbstractHorseInventory probably unimportant though
  • New methods in EnderSignal
  • Slime - getTarget()LivingEntity, setTarget(LivingEntity)
  • Arrow - isInBlock()Z, getAttachedBlock()Block - arrows in a block are motionless and may be picked up by players

Added in 1.13

  • Entity - isSwimming()Z, setSwimming(Z)
  • EntityToggleSwimEvent extends EntityEvent implements Cancellable
    • getEntity()Entity
    • isSwimming()Z
  • all the other additions listed before in this issue

Other (not really related)

  • 4 new advancements, but Skript doesn't have advancemenet support
  • new sounds
  • new statistic used by phantoms (time_since_rest)
@TheBentoBox
Copy link
Member

I did already have something like this in #751, but yours is much newer and less cluttered with technical stuff/details so I think we can swap to using your list here. Can you just add the new entities as well? Those being Dolphins, Drowned, Phantom, Turtle, Cod, Salmon, Pufferfish, and Tropical Fish.

Also on the note of the new entities, as described in dev22g's release there are some entity supertypes. I'm not sure if there's a supertype for zombies (it's not listed there), but if there isn't one it should be added and the new Drowned mobs should be a part of it. There should also be a fish supertype for the four fish mobs that exist now.

@TheBentoBox
Copy link
Member

Also, entity swim state API and swim toggle event. Should be supported just like elytra glide states.

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: high Issues with potentially high impact that could be harmful to users. labels Jul 17, 2018
@TheBentoBox
Copy link
Member

Closed #751 in favor of this now. Setting to high priority as 1.13 is very close. Aliases rework first, then this stuff immediately.

@bensku bensku mentioned this issue Jul 19, 2018
7 tasks
@bensku
Copy link
Member

bensku commented Jul 19, 2018

Opened another branch for immediate "get it running" issue.

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jul 23, 2018

Player#hidePlayer and Player.showPlayer is already added in Skript by @Blueyescat if it was changed and it's not already supported it should be modified in the 1.13 branch blue.

Only thing that was changed in the EnderSignal was the despawn timer.

Status effect as in Potion effect?

And finally they added isInWater/isSwimming it's been a method in NMS for a long time and very easy to add, I never understood why they never added it.

@Blueyescat
Copy link
Contributor

Blueyescat commented Jul 23, 2018

@TheLimeGlass I knew that and already added support for the new methods (added in 1.12.2, not 1.13).
So no problem 🙂

targetPlayer.showPlayer(Skript.getInstance(), player);

@ShaneBeee
Copy link
Contributor

hey @Nicofisi I was skimming thru the Spigot API and saw a couple more particles for you to add to your list
Particle DOLPHIN
Particle NAUTILUS
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Particle.html#NAUTILUS

@TheBentoBox
Copy link
Member

I've added them to the post just now, thanks @ShaneBeee , good catch

bensku pushed a commit that referenced this issue Feb 3, 2020
* Create ExprCreeperMaxFuseTicks.java

* methodExists

* Missing Import

* Fix RESET
@Misio12320
Copy link

What's the status of work? Just a question.

@ShaneBeee
Copy link
Contributor

What's the status of work? Just a question.

What exactly are you wanting to know? And why exactly are you worried about this?

There is not ETA and/or timeline for the issues mentioned in this thread. Things will get done when they get done.

If you wish to see that checklist get finished, you are more than welcome to do some PRs to contribute to the things that need to get done.

@APickledWalrus APickledWalrus added good first issue An issue that would be good for a first-time contributor to make a PR for priority: low Issues that are not harmful to the experience but are related to useful changes or additions. and removed priority: high Issues with potentially high impact that could be harmful to users. labels Sep 24, 2020
@APickledWalrus
Copy link
Member

APickledWalrus commented Sep 24, 2020

What's left in this is no longer of high priority. However, these features would still be nice to have. PRs welcome 🎉

EDIT: Probably going to implement the mending feature myself very soon.

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jan 27, 2022

All that's left are entity/block suggestions. Which an addon like Khoryl focuses on because exact entity types have to be determined at runtime, something that's not logical for Skript erroring and requires janky runtime erroring. Potential close on this?

@TheLimeGlass TheLimeGlass added PR available Issues which have a yet-to-be merged PR resolving it and removed good first issue An issue that would be good for a first-time contributor to make a PR for labels Apr 19, 2023
@TheLimeGlass
Copy link
Collaborator

Closable after #5617, entities are not currently supported in Skript due to runtime limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

8 participants