Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explosive Entity Yield Expressions #2782

Merged
merged 8 commits into from
Jul 20, 2020
Merged

Explosive Entity Yield Expressions #2782

merged 8 commits into from
Jul 20, 2020

Conversation

APickledWalrus
Copy link
Member

@APickledWalrus APickledWalrus commented Jan 19, 2020 •
edited
Loading

Description

This PR is the same as #2776 but for the other explosive entities and for the explosion prime event. Right now, the syntax will conflict with that PR so we will need to decide what to do about that.

Target Minecraft Versions: Any
Requirements: None
Related Issues: None

@APickledWalrus APickledWalrus changed the title Add expressions Explosive Entity Yield Expressions Jan 19, 2020
@Wealthyturtle Wealthyturtle added the feature Pull request adding a new feature. label Jan 21, 2020
@bensku bensku mentioned this pull request Feb 3, 2020
Closed
ShaneBeee
ShaneBeee suggested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just a few small changes requested.
I did play around with the Explosive Entity Explosion Yield expression and had a heck of a lot of fun with it.

src/main/java/ch/njol/skript/expressions/ExprExplosionPrimeEventYield.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprExplosionPrimeEventYield.java Outdated Show resolved Hide resolved
@APickledWalrus
Copy link
Member Author

I realize now that the tests can just be in one file, so ill fix that soon

@APickledWalrus APickledWalrus added this to the 2.5 milestone Jul 10, 2020
@APickledWalrus
Copy link
Member Author

Ready for (hopefully) the final reviews.

@ShaneBeee ShaneBeee merged commit e0477a5 into SkriptLang:master Jul 20, 2020
@APickledWalrus APickledWalrus deleted the APickledWalrus-expr-explosiveyield branch September 24, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@Pikachu920 Pikachu920 Pikachu920 left review comments

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@APickledWalrus @ShaneBeee @Pikachu920 @Wealthyturtle