Creeper Explosion Radius Expression #2776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueyescat
reviewed
Jan 18, 2020
src/main/java/ch/njol/skript/expressions/ExprCreeperExplosionRadius.java
Outdated
Show resolved
Hide resolved
|
Might be nice to expand this to other entities that explode (see https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Explosive.html) |
|
Creepers are not instances of Explosive tho. |
|
yeah... I learned that with my PR from earlier haha. I may PR this but for the other entities. |
|
I'd prefer to have this tested, unless it requires online players. Aside that, we shouldn't expose faults of Spigot API to scripters. If creepers are not explosives, they could be made special cases in #2782. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to get/set a Creeper entity's explosion radius.
Target Minecraft Versions: "Added after 1.12.2", so I used methodExists()
Requirements: None
Related Issues: #1385