Add server broadcast event #5617

TheLimeGlass · 2023-04-19T03:25:02Z

Description

Add server broadcast event

Target Minecraft Versions: none
Requirements: none
Related Issues: #1385 (closing as complete), #4185 (non-closing)

NotSoDelayed · 2023-04-19T04:10:39Z

Apart from built-in advertisements like Serverpro which will trigger this event, there’s no other way that this event will be triggered within the Skript environment as EffBroadcast does not use Server#broadcast(java.lang.String,java.lang.String), as shown here.

AyhamAl-Ali

Nice PR ⚡

src/main/java/ch/njol/skript/events/SimpleEvents.java

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/expressions/ExprMessage.java

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/events/SimpleEvents.java

AyhamAl-Ali · 2023-04-19T10:08:29Z

Apart from built-in advertisements like Serverpro which will trigger this event, there’s no other way that this event will be triggered within the Skript environment as EffBroadcast does not use Server#broadcast(java.lang.String,java.lang.String), as shown here.

I wonder why Skript doesn't use https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Server.html#broadcastMessage(java.lang.String) here?

bluelhf · 2023-04-19T12:26:40Z

Apart from built-in advertisements like Serverpro which will trigger this event, there’s no other way that this event will be triggered within the Skript environment as EffBroadcast does not use Server#broadcast(java.lang.String,java.lang.String), as shown here.

I wonder why Skript doesn't use https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Server.html#broadcastMessage(java.lang.String) here?

Likely because EffBroadcast also supports sending broadcasts to a specific world, which means special handling would be required to use broadcastMessage (and at the time it was added there was probably no incentive to do so, as sending the messages to each sender individually achieved the same effect)

Pikachu920 · 2023-04-19T17:11:44Z

Apart from built-in advertisements like Serverpro which will trigger this event, there’s no other way that this event will be triggered within the Skript environment as EffBroadcast does not use Server#broadcast(java.lang.String,java.lang.String), as shown here.

I wonder why Skript doesn't use https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Server.html#broadcastMessage(java.lang.String) here?

Likely because EffBroadcast also supports sending broadcasts to a specific world, which means special handling would be required to use broadcastMessage (and at the time it was added there was probably no incentive to do so, as sending the messages to each sender individually achieved the same effect)

EffBroadcast could call the event manually. it would have to strip the formatting for the event, but thats probably fine.

TheLimeGlass · 2023-04-19T22:51:13Z

EffBroadcast could use Server#broadcast as it supports components now.

bluelhf · 2023-04-20T07:17:14Z

EffBroadcast could use Server#broadcast as it supports components now.

That doesn't work for specific worlds, though, which would mean we'd still need to trigger the event manually. Maybe we'd be better off just calling the event manually in any case?

Co-authored-by: Ayham Al Ali <[email protected]>

src/main/java/ch/njol/skript/events/SimpleEvents.java

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/expressions/ExprMessage.java

Co-authored-by: Ayham Al Ali <[email protected]>

UnderscoreTud · 2023-10-18T19:35:36Z

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

@@ -113,8 +110,28 @@ public void change(Event event, @Nullable Object[] delta, ChangeMode mode) {
 			case REMOVE_ALL:


I know that this is the current behavior, but why does REMOVE_ALL as RESET and DELETE? remove all {_x} from the chat recipients shouldn't just remove all the recipients. I don't believe it should be supported here at all anyway, as there can only be one of a recipient, not more.

Also shouldn't resetting the recipients add all players back in, rather than clearing them? Because that's what I interpret from the RESET change mode - to reset the value to how it originally is; in this case all the players

Sorry, why did you mark this as resolved?

Not resolved

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/expressions/ExprMessage.java

Co-authored-by: _tud <[email protected]>

sovdeeth

Looks good to me!

src/main/java/ch/njol/skript/events/SimpleEvents.java

Co-authored-by: sovdee <[email protected]>

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/events/SimpleEvents.java

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

UnderscoreTud · 2024-08-19T19:56:54Z

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

+		if (event instanceof AsyncPlayerChatEvent) {
+			return ((AsyncPlayerChatEvent) event).getRecipients().toArray(new Player[0]);
+		} else if (event instanceof BroadcastMessageEvent) {
+			return ((BroadcastMessageEvent) event).getRecipients().toArray(new CommandSender[0]);
+		}


Could use instanceof patterns since we now support Java 17

UnderscoreTud · 2024-08-19T19:58:00Z

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

@@ -113,8 +110,28 @@ public void change(Event event, @Nullable Object[] delta, ChangeMode mode) {
 			case REMOVE_ALL:


Sorry, why did you mark this as resolved?

UnderscoreTud · 2024-08-19T19:59:32Z

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

+				if (event instanceof AsyncPlayerChatEvent) {
+					((AsyncPlayerChatEvent) event).getRecipients().clear();
+				} else {
+					((BroadcastMessageEvent) event).getRecipients().clear();
+				}


Could use instanceof pattern

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

src/main/java/ch/njol/skript/expressions/ExprMessage.java

Moderocky

Looks good, a couple of minor formatting bits :)

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

Co-authored-by: Moderocky <[email protected]>

Co-authored-by: _tud <[email protected]>

Co-authored-by: Moderocky <[email protected]>

Co-authored-by: _tud <[email protected]>

Moderocky

Looking better.

src/main/java/ch/njol/skript/expressions/ExprMessage.java

Add server broadcast event

804b7ab

TheLimeGlass added the feature Pull request adding a new feature. label Apr 19, 2023

TheLimeGlass mentioned this pull request Apr 19, 2023

New features from 1.13 #1385

Open

59 tasks

Update description

0506270

AyhamAl-Ali requested changes Apr 19, 2023

View reviewed changes

TheLimeGlass and others added 4 commits July 30, 2023 02:54

Update src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

5d1258d

Co-authored-by: Ayham Al Ali <[email protected]>

Merge branch 'master' into feature/broadcast-event

85167f5

Update src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

10b7621

Co-authored-by: Ayham Al Ali <[email protected]>

Address reviews

9140798

TheLimeGlass requested review from AyhamAl-Ali, APickledWalrus and UnderscoreTud July 30, 2023 09:05

AyhamAl-Ali requested changes Jul 30, 2023

View reviewed changes

TheLimeGlass and others added 3 commits July 30, 2023 15:07

Update src/main/java/ch/njol/skript/events/SimpleEvents.java

99c4a10

Co-authored-by: Ayham Al Ali <[email protected]>

Apply suggestions from code review

087ad0d

Co-authored-by: Ayham Al Ali <[email protected]>

Update src/main/java/ch/njol/skript/events/SimpleEvents.java

560f226

Co-authored-by: Ayham Al Ali <[email protected]>

TheLimeGlass requested a review from AyhamAl-Ali July 30, 2023 21:10

NotSoDelayed mentioned this pull request Sep 8, 2023

Make EffBroadcast calls BroadcastMessageEvent #5979

Merged

Moderocky force-pushed the master branch 3 times, most recently from bd134d0 to 3f08853 Compare September 16, 2023 16:59

Moderocky changed the base branch from master to dev/feature September 18, 2023 10:37

Merge branch 'dev/feature' into feature/broadcast-event

b2edd26

TheLimeGlass requested a review from sovdeeth October 17, 2023 08:15

UnderscoreTud requested changes Oct 18, 2023

View reviewed changes

TheLimeGlass and others added 2 commits October 28, 2023 03:43

Update ExprChatRecipients.java

bb5b5cf

Update src/main/java/ch/njol/skript/expressions/ExprMessage.java

9715640

Co-authored-by: _tud <[email protected]>

sovdeeth approved these changes Oct 28, 2023

View reviewed changes

sovdeeth added the 2.8 Targeting a 2.8.X version release label Dec 30, 2023

Merge branch 'dev/feature' into feature/broadcast-event

fe4c87c

sovdeeth approved these changes Dec 30, 2023

View reviewed changes

src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated Show resolved Hide resolved

Update src/main/java/ch/njol/skript/events/SimpleEvents.java

a6e8e61

Co-authored-by: sovdee <[email protected]>

sovdeeth added 2.9 Targeting a 2.9.X version release and removed 2.8 Targeting a 2.8.X version release labels Jan 5, 2024

Merge branch 'dev/feature' into feature/broadcast-event

c036074

sovdeeth removed the 2.9 Targeting a 2.9.X version release label Jul 1, 2024

APickledWalrus approved these changes Aug 16, 2024

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java Outdated Show resolved Hide resolved

APickledWalrus requested a review from UnderscoreTud August 16, 2024 20:41

UnderscoreTud requested changes Aug 19, 2024

View reviewed changes

Moderocky requested changes Aug 20, 2024

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java Outdated Show resolved Hide resolved

src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java Outdated Show resolved Hide resolved

TheLimeGlass and others added 4 commits September 7, 2024 03:35

Update src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

5664351

Co-authored-by: Moderocky <[email protected]>

Update src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

283b2d5

Co-authored-by: _tud <[email protected]>

Update src/main/java/ch/njol/skript/expressions/ExprChatRecipients.java

81141eb

Co-authored-by: Moderocky <[email protected]>

Update src/main/java/ch/njol/skript/events/SimpleEvents.java

11fc732

Co-authored-by: _tud <[email protected]>

TheLimeGlass requested a review from Moderocky September 7, 2024 09:39

Moderocky approved these changes Sep 8, 2024

View reviewed changes

Merge branch 'dev/feature' into feature/broadcast-event

5515432

Moderocky reviewed Sep 8, 2024

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprMessage.java Outdated Show resolved Hide resolved

Update src/main/java/ch/njol/skript/expressions/ExprMessage.java

6fb4b2b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add server broadcast event #5617

Add server broadcast event #5617

TheLimeGlass commented Apr 19, 2023 •

edited

Loading

NotSoDelayed commented Apr 19, 2023 •

edited

Loading

AyhamAl-Ali left a comment

AyhamAl-Ali commented Apr 19, 2023 •

edited

Loading

bluelhf commented Apr 19, 2023

Pikachu920 commented Apr 19, 2023

TheLimeGlass commented Apr 19, 2023

bluelhf commented Apr 20, 2023

UnderscoreTud Oct 18, 2023

UnderscoreTud Aug 19, 2024

UnderscoreTud Sep 8, 2024

sovdeeth left a comment

UnderscoreTud Aug 19, 2024

UnderscoreTud Aug 19, 2024

UnderscoreTud Aug 19, 2024

Moderocky left a comment

Moderocky left a comment

		@@ -113,8 +110,28 @@ public void change(Event event, @Nullable Object[] delta, ChangeMode mode) {
		case REMOVE_ALL:

Add server broadcast event #5617

Are you sure you want to change the base?

Add server broadcast event #5617

Conversation

TheLimeGlass commented Apr 19, 2023 • edited Loading

Description

NotSoDelayed commented Apr 19, 2023 • edited Loading

AyhamAl-Ali left a comment

Choose a reason for hiding this comment

AyhamAl-Ali commented Apr 19, 2023 • edited Loading

bluelhf commented Apr 19, 2023

Pikachu920 commented Apr 19, 2023

TheLimeGlass commented Apr 19, 2023

bluelhf commented Apr 20, 2023

UnderscoreTud Oct 18, 2023

Choose a reason for hiding this comment

UnderscoreTud Aug 19, 2024

Choose a reason for hiding this comment

UnderscoreTud Sep 8, 2024

Choose a reason for hiding this comment

sovdeeth left a comment

Choose a reason for hiding this comment

UnderscoreTud Aug 19, 2024

Choose a reason for hiding this comment

UnderscoreTud Aug 19, 2024

Choose a reason for hiding this comment

UnderscoreTud Aug 19, 2024

Choose a reason for hiding this comment

Moderocky left a comment

Choose a reason for hiding this comment

Moderocky left a comment

Choose a reason for hiding this comment

TheLimeGlass commented Apr 19, 2023 •

edited

Loading

NotSoDelayed commented Apr 19, 2023 •

edited

Loading

AyhamAl-Ali commented Apr 19, 2023 •

edited

Loading