Add list of keyboard shortcuts to document settings #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesomeplayer165
requested changes
Apr 10, 2024
| Space: "Start/stop path playback", | ||
| Escape: "Clear sidebar and navbar selection" | ||
| }, | ||
| "Field View": { |
There was a problem hiding this comment.
why are some keys with quotes and some without? Are we trying to keep single words without quotes? Is there a purpose between differentiating?
There was a problem hiding this comment.
The Prettier formatter unquoted the ones with single words. IDK if it's worth figuring out how to ignore it here
There was a problem hiding this comment.
then thats fine.
| E: "Rotates 1/32 turn clockwise", | ||
| Q: "Rotates 1/32 turn counterclockwise", | ||
| "Shift + Rotation Key": "Rotate by 1/8 turn instead of 1/32 turn", | ||
| W: "Translate 0.1 m up (+Y)", |
There was a problem hiding this comment.
Doesn't this decrease y value?
There was a problem hiding this comment.
I don't know what you're seeing but upwards on the screen is increasing Y
| @@ -68,17 +69,28 @@ class SettingsModal extends Component<Props, State> { | |||
| <Tab label="Robot Config" /> | |||
| <Tab label="Export Config" /> | |||
| <Tab label="Betas" /> | |||
| <Tab label="Controls" /> | |||
There was a problem hiding this comment.
should controls go before betas?
| isMac = (type == "Darwin"); | ||
| }) | ||
| // These default to the Mac ⌘ key because it's easier to replace with Ctrl than vice versa | ||
| let shortcuts = { |
There was a problem hiding this comment.
all of these should be flipped. I see people looking for what is the generate key to find the shortcut. not, oh i forgot what command G does?
tldr should be descriptions on left and the shortcut on right (flipped).
| > | ||
| {Object.entries(shortcuts).map((entry) => ( | ||
| <> | ||
| <Accordion> |
There was a problem hiding this comment.
What is this gap doing here?
Co-authored-by: Jacob Trentini <[email protected]>
spacey-sooty
pushed a commit
to spacey-sooty/Choreo
that referenced
this pull request
Jun 23, 2024
idk why but my ide is acting up so there are probably errors that ill fix later. Anyway, I added a static field in Choreo.java which stores the current trajectory that the robot is on. Calling choreoSwerveCommand() will update this to the trajectory it is given, and then, when finished, put it back to an empty trajectory. There is also now a new static event() method in Choreo.java which returns a trigger for if the robot is currently on a trajectory given as an argument. holy guacamole i forgot a semicolon imported trigger i mightve jumped the gun but i was bored so heres another event function. is this good more methodsgit add .! more le fixes Add list of keyboard shortcuts to document settings (SleipnirGroup#447) Co-authored-by: Jacob Trentini <[email protected]> Feature: Context Menu (SleipnirGroup#448) * add context menu with popover * format * silence error with conflicting mouseevent * format * works but only if you hot reload (fixing with next commit) * step 1 out of predicted 2: migrate local state to uiState * step 2/2: move d3 callback to overlaywaypoint * format * format and refactorings * address @calcmogul's concerns Upgrade TrajoptLib to use larger solver tolerance (SleipnirGroup#451) organization and comments renaming cleanup java impl fix docs format
spacey-sooty
pushed a commit
to spacey-sooty/Choreo
that referenced
this pull request
Jun 23, 2024
idk why but my ide is acting up so there are probably errors that ill fix later. Anyway, I added a static field in Choreo.java which stores the current trajectory that the robot is on. Calling choreoSwerveCommand() will update this to the trajectory it is given, and then, when finished, put it back to an empty trajectory. There is also now a new static event() method in Choreo.java which returns a trigger for if the robot is currently on a trajectory given as an argument. holy guacamole i forgot a semicolon imported trigger i mightve jumped the gun but i was bored so heres another event function. is this good more methodsgit add .! more le fixes Add list of keyboard shortcuts to document settings (SleipnirGroup#447) Co-authored-by: Jacob Trentini <[email protected]> Feature: Context Menu (SleipnirGroup#448) * add context menu with popover * format * silence error with conflicting mouseevent * format * works but only if you hot reload (fixing with next commit) * step 1 out of predicted 2: migrate local state to uiState * step 2/2: move d3 callback to overlaywaypoint * format * format and refactorings * address @calcmogul's concerns Upgrade TrajoptLib to use larger solver tolerance (SleipnirGroup#451) organization and comments renaming cleanup java impl fix docs format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373
Ctrl/Command key is shown depending on the user's detected OS