Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Policy SDK update #2593

Closed
sfc-gh-jcieslak opened this issue Mar 6, 2024 · 6 comments · Fixed by #2647
Closed

Network Policy SDK update #2593

sfc-gh-jcieslak opened this issue Mar 6, 2024 · 6 comments · Fixed by #2647
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@sfc-gh-jcieslak
Copy link
Collaborator

sfc-gh-jcieslak commented Mar 6, 2024 •
edited
Loading

Use Cases or Problem Statement

Follow up for #2514. Because there were new fields added to the documentation, we have to adjust the current implementation in the SDK to support those new fields.

How much impact is this issue causing?

Medium

Additional Information

Resource implementation reference: #2482
@sfc-gh-jcieslak sfc-gh-jcieslak added the feature-request Used to mark issues with provider's missing functionalities label Mar 6, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this issue Mar 6, 2024
Closed
@freakyfriday
Copy link

Hi team, any update on when this feature might be implemented? Thanks :-)

@Relativity74205
Copy link
Contributor

@sfc-gh-jcieslak Like posted #2482 the headline for this issue is wrong. The network rules SDK was already created and it is fine. But the network policy SDK has to be updated in order to use the network rules.

@sfc-gh-jcieslak sfc-gh-jcieslak changed the title Network Rule SDK update Network Policy SDK update Mar 20, 2024
@sfc-gh-jcieslak
Copy link
Collaborator Author

@Relativity74205 True, thanks :)
Sorry, It looks like we have no team capacity for it right now, but let me consult with the team if we could somehow squeeze this in.

@Relativity74205
Copy link
Contributor

@sfc-gh-jcieslak That would be great. As soon as the SDK update is finished, it would start implement the network rule feature

@sfc-gh-swinkler sfc-gh-swinkler mentioned this issue Mar 25, 2024
Merged
2 tasks
@Relativity74205
Copy link
Contributor

@sfc-gh-jcieslak I see, that a PR was created two weeks ago, however, it ran into some issues. Can I support here somehow?

@sfc-gh-asawicki
Copy link
Collaborator

Hey @Relativity74205. @sfc-gh-swinkler was working on it but is only partially involved in the project. Today, we'll discuss whether we can speed it up because this PR is nearly merged.

sfc-gh-asawicki pushed a commit that referenced this issue Apr 16, 2024
@sfc-gh-swinkler
fix: network policy update (#2647)
8126b28 
fixes #2593 

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: network policy update Snowflake-Labs/terraform-provider-snowflake
4 participants
@freakyfriday @Relativity74205 @sfc-gh-jcieslak @sfc-gh-asawicki