-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: network policy update #2647
Conversation
Integration tests failure for 6d4fc141ef50c86962c5cae97d911cac07efefba |
Integration tests failure for 2e0e837b95476c85e6d69359b2c7c403bbfd9ca9 |
g.KeywordOptions().SQL("SET"), | ||
). | ||
OptionalQueryStructField( | ||
"Add", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs ADD and REMOVE both take only one network rule and not the list like CREATE/ALTER SET. Is this the error in the docs or in the implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs are wrong, it should be a list, i tried one network rule, and it failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add it to the doc discuss channel, and then you can close this comment
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10002067 | Triggered | GitHub Access Token | f9b7255 | .github/GITHUB_README.md | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Integration tests failure for f9b72554c173d724cdcd4cae85b351fafb2398c1 |
Integration tests success for f9b72554c173d724cdcd4cae85b351fafb2398c1 |
🤖 I have created a release *beep* *boop* --- ## [0.89.0](v0.88.0...v0.89.0) (2024-04-18) ### 🎉 **What's new:** * Update target objects for privilege-granting resources ([#2688](#2688)) ([74e2b6b](74e2b6b)) ### 🔧 **Misc** * Handle generic check destroy in acceptance tests ([#2716](#2716)) ([63a5324](63a5324)) * Initialize the SDK client in fewer places ([#2710](#2710)) ([382bfc1](382bfc1)) ### 🐛 **Bug fixes:** * Adds case statement for ObjectTypeUser in ShowObjectParameter. ([#2675](#2675)) ([23a3341](23a3341)) * diffs always occurring when multiple columns exist ([#2686](#2686)) ([3275ad4](3275ad4)) * Fix issues [#2679](#2679) [#2721](#2721) ([#2723](#2723)) ([b0c9dd4](b0c9dd4)) * Fix several small issues ([#2697](#2697)) ([e3f6a15](e3f6a15)) * granting ownership on database roles ([#2703](#2703)) ([88944e7](88944e7)) * network policy update ([#2647](#2647)) ([8126b28](8126b28)) * Rename grants_redesign_desgin_decisions.md to grants_redesign_design_… ([#2691](#2691)) ([5000b2b](5000b2b)) * renames in update operations ([#2702](#2702)) ([793c879](793c879)) * showbyid method tests ([#2648](#2648)) ([ff5e617](ff5e617)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
fixes #2593
Test Plan
References