fix: renames in update operations #2702
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9467623 | Triggered | Generic Password | 1f80645 | pkg/resources/password_policy_acceptance_test.go | View secret |
| 9467623 | Triggered | Generic Password | 1f80645 | pkg/resources/password_policy_acceptance_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Integration tests failure for d084e27ed2a1fb8a8046ae881cdc4fac579623c6 |
|
Integration tests failure for 1f806454b935900ea745f364c8b5453a25950e8f |
|
Integration tests failure for d084e27ed2a1fb8a8046ae881cdc4fac579623c6 |
|
Integration tests failure for 7217ab72d3d674cd0dc90bb266021a4596ed3824 |
|
Integration tests failure for c5c3ab623c2c8e220456b03a9e137c704446641a |
1 similar comment
|
Integration tests failure for c5c3ab623c2c8e220456b03a9e137c704446641a |
|
Integration tests success for 0501ff30d5c7c5f7d56970a8e02f7b42f59ed2f1 |
🤖 I have created a release *beep* *boop* --- ## [0.89.0](v0.88.0...v0.89.0) (2024-04-18) ### 🎉 **What's new:** * Update target objects for privilege-granting resources ([#2688](#2688)) ([74e2b6b](74e2b6b)) ### 🔧 **Misc** * Handle generic check destroy in acceptance tests ([#2716](#2716)) ([63a5324](63a5324)) * Initialize the SDK client in fewer places ([#2710](#2710)) ([382bfc1](382bfc1)) ### 🐛 **Bug fixes:** * Adds case statement for ObjectTypeUser in ShowObjectParameter. ([#2675](#2675)) ([23a3341](23a3341)) * diffs always occurring when multiple columns exist ([#2686](#2686)) ([3275ad4](3275ad4)) * Fix issues [#2679](#2679) [#2721](#2721) ([#2723](#2723)) ([b0c9dd4](b0c9dd4)) * Fix several small issues ([#2697](#2697)) ([e3f6a15](e3f6a15)) * granting ownership on database roles ([#2703](#2703)) ([88944e7](88944e7)) * network policy update ([#2647](#2647)) ([8126b28](8126b28)) * Rename grants_redesign_desgin_decisions.md to grants_redesign_design_… ([#2691](#2691)) ([5000b2b](5000b2b)) * renames in update operations ([#2702](#2702)) ([793c879](793c879)) * showbyid method tests ([#2648](#2648)) ([ff5e617](ff5e617)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
This change fixes all of the Updates that were performing re-names to always setId at the end of the rename operation as well as updating id that was used in the later operations. Also, the
ForceNews were removed in cases where rename was also handled in the Update. Test cases were added to show that rename is going through Update and not DeleteAndCreate operation + additional param is always changed to see if other operations are affected by the previous rename operation. The table constraint was adjusted and cannot support the rename for now (until the Read operation is working #2683). Migration guide updated for behavioral changes.