Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags_validations.go incorrectly restricting AllowedValues field: between 1 and 50 #2721

Closed
ajain-coveo opened this issue Apr 17, 2024 · 3 comments
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@ajain-coveo
Copy link

ajain-coveo commented Apr 17, 2024

Terraform CLI and Provider Versions

Terraform v1.7.4
Snowflake Provider version = "0.88.0"

Terraform Configuration

N/A

Expected Behavior

allowed_values in snowflake_tag resource should not be restricted to 50. Snowflake has that tag restriction of 50 only at the object level ==> Snowflake allows a maximum number of 50 unique tags that can be set on a single object.
But this restriction does not apply to the number of allowed values on a tag.

resource "snowflake_tag" "tag" {
name = "cost_center"
database = snowflake_database.database.name
schema = snowflake_schema.schema.name
allowed_values = ["finance", "engineering",........] ==> This should not have restriction of 50
}

Actual Behavior

When allowed_values list has more than 50 items getting following error while creating snowwflake_tag resource:

Error: [tags_validations.go:39] AllowedValues field: Values must be between 1 and 50

Steps to Reproduce

  1. terraform apply

How much impact is this issue causing?

High

Logs

No response

Additional Information

Error: [tags_validations.go:39] AllowedValues field: Values must be between 1 and 50

@ajain-coveo ajain-coveo added the bug Used to mark issues with provider's incorrect behavior label Apr 17, 2024
@ajain-coveo ajain-coveo changed the title tags_validations.go incorrectly restricting AllowedValues field: Values must be between 1 and 50 tags_validations.go incorrectly restricting AllowedValues field: between 1 and 50 Apr 17, 2024
@sfc-gh-asawicki sfc-gh-asawicki added feature-request Used to mark issues with provider's missing functionalities and removed bug Used to mark issues with provider's incorrect behavior labels Apr 17, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @ajain-coveo. Thanks for reaching out to us.

As I can see, it was updated in Snowflake Nov. 27, 2023. We plan to work on such differences with upcoming resources redesign https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#supporting-all-snowflake-ga-features. This is a really small change, though, I will try to include it in tomorrow's release.

sfc-gh-asawicki added a commit that referenced this issue Apr 18, 2024
sfc-gh-asawicki added a commit that referenced this issue Apr 18, 2024
- Fix number of allowed values in tags
- Suppress diff for stages `on_error`
sfc-gh-jcieslak pushed a commit that referenced this issue Apr 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.0](v0.88.0...v0.89.0)
(2024-04-18)


### 🎉 **What's new:**

* Update target objects for privilege-granting resources
([#2688](#2688))
([74e2b6b](74e2b6b))


### 🔧 **Misc**

* Handle generic check destroy in acceptance tests
([#2716](#2716))
([63a5324](63a5324))
* Initialize the SDK client in fewer places
([#2710](#2710))
([382bfc1](382bfc1))


### 🐛 **Bug fixes:**

* Adds case statement for ObjectTypeUser in ShowObjectParameter.
([#2675](#2675))
([23a3341](23a3341))
* diffs always occurring when multiple columns exist
([#2686](#2686))
([3275ad4](3275ad4))
* Fix issues
[#2679](#2679)
[#2721](#2721)
([#2723](#2723))
([b0c9dd4](b0c9dd4))
* Fix several small issues
([#2697](#2697))
([e3f6a15](e3f6a15))
* granting ownership on database roles
([#2703](#2703))
([88944e7](88944e7))
* network policy update
([#2647](#2647))
([8126b28](8126b28))
* Rename grants_redesign_desgin_decisions.md to grants_redesign_design_…
([#2691](#2691))
([5000b2b](5000b2b))
* renames in update operations
([#2702](#2702))
([793c879](793c879))
* showbyid method tests
([#2648](#2648))
([ff5e617](ff5e617))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@sfc-gh-asawicki
Copy link
Collaborator

Hey @ajain-coveo. We have released new version with the requested changes: https://github.com/Snowflake-Labs/terraform-provider-snowflake/releases/tag/v0.89.0. Please bump and confirm that it works.

@sfc-gh-asawicki
Copy link
Collaborator

Closing as fixed. Please open a new issue if the problem persists in the newest provider version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Development

No branches or pull requests

2 participants