Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Initialize the SDK client in fewer places #2710

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Apr 15, 2024

Result of SNOW-935947.

  • the SDK default client was already setup earlier in the acceptance tests context; used in all valid places
  • added secondary client setup to acceptance tests context and used in valid places

Copy link

Integration tests failure for 14fc5ea2c76f360b5286af550de0b880ff2fabf7

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review April 15, 2024 12:57
pkg/acceptance/testing.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 3f93a9ab584e61c40c0e49f06adb06accef75ff7

Copy link

Integration tests success for 3f93a9ab584e61c40c0e49f06adb06accef75ff7

@sfc-gh-asawicki sfc-gh-asawicki merged commit 382bfc1 into main Apr 16, 2024
9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the initialize-sdk-client-in-fewer-places branch April 16, 2024 07:11
sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.0](v0.88.0...v0.89.0)
(2024-04-18)


### 🎉 **What's new:**

* Update target objects for privilege-granting resources
([#2688](#2688))
([74e2b6b](74e2b6b))


### 🔧 **Misc**

* Handle generic check destroy in acceptance tests
([#2716](#2716))
([63a5324](63a5324))
* Initialize the SDK client in fewer places
([#2710](#2710))
([382bfc1](382bfc1))


### 🐛 **Bug fixes:**

* Adds case statement for ObjectTypeUser in ShowObjectParameter.
([#2675](#2675))
([23a3341](23a3341))
* diffs always occurring when multiple columns exist
([#2686](#2686))
([3275ad4](3275ad4))
* Fix issues
[#2679](#2679)
[#2721](#2721)
([#2723](#2723))
([b0c9dd4](b0c9dd4))
* Fix several small issues
([#2697](#2697))
([e3f6a15](e3f6a15))
* granting ownership on database roles
([#2703](#2703))
([88944e7](88944e7))
* network policy update
([#2647](#2647))
([8126b28](8126b28))
* Rename grants_redesign_desgin_decisions.md to grants_redesign_design_…
([#2691](#2691))
([5000b2b](5000b2b))
* renames in update operations
([#2702](#2702))
([793c879](793c879))
* showbyid method tests
([#2648](#2648))
([ff5e617](ff5e617))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants