feat: Rework user resource #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there is still test "create and alter: problems with public key fingerprints"
References: #1572
sfc-gh-asawicki
commented
Aug 30, 2024
|
Integration tests failure for 4a14f26bc7b4a8a0f16dc22e35adb92831f1cd26 |
sfc-gh-jcieslak
approved these changes
Aug 30, 2024
|
Integration tests failure for 0a6eeeff1365e0f9eace05302f585266986b0c62 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.95.0](v0.94.1...v0.95.0) (2024-09-04) ### 🎉 **What's new:** * Add change_tracking, row access policy and aggregation policy to views ([#2988](#2988)) ([1f88bb1](1f88bb1)) * Add fully_qualified_name to all resources ([#2990](#2990)) ([1b0462f](1b0462f)) * Add identifier parsers ([#2957](#2957)) ([824ec52](824ec52)) * Add identifier with arguments ([#2979](#2979)) ([00ae1c5](00ae1c5)) * Add timeouts block to cortex ([#3004](#3004)) ([34d764b](34d764b)) * Add user parameters to resource ([#2968](#2968)) ([f4ae380](f4ae380)) * Conclude user rework ([#3036](#3036)) ([23e4625](23e4625)) * database role v1 readiness ([#3014](#3014)) ([c4db255](c4db255)) * Identifier with arguments for procedure and external function ([#2987](#2987)) ([f13cc5c](f13cc5c)) * Rework user resource ([#3026](#3026)) ([bde2638](bde2638)), closes [#1572](#1572) * Rework users datasource ([#3030](#3030)) ([751239b](751239b)), closes [#2902](#2902) * Upgrade view sdk ([#2969](#2969)) ([ef2d50a](ef2d50a)) * View rework part 2 ([#3021](#3021)) ([e05377d](e05377d)) * View rework part 3 ([#3023](#3023)) ([195b41c](195b41c)) ### 🔧 **Misc** * Add annotation about fully_qualified_name and fix handling granteeName ([#3009](#3009)) ([94e6345](94e6345)) * Apply identifier conventions ([#2996](#2996)) ([5cbea84](5cbea84)) * apply identifier conventions to grants ([#3008](#3008)) ([d7780ae](d7780ae)) * Clean collection utils ([#3028](#3028)) ([426ddb1](426ddb1)) * Clean old assertions ([#3029](#3029)) ([ad657eb](ad657eb)) * Conclude identifiers rework ([#3011](#3011)) ([c1b53f3](c1b53f3)) * Improve user test and add manual test for user default database and role ([#3035](#3035)) ([6cb0b4e](6cb0b4e)) * Use new identifier with arguments in function, external function and procedure grants ([#3002](#3002)) ([5053f8b](5053f8b)) * User improvements ([#3034](#3034)) ([65b64d7](65b64d7)) ### 🐛 **Bug fixes:** * database tests and introduce a new parameter ([#2981](#2981)) ([3bae7f6](3bae7f6)) * Fix custom diffs for fields with diff supression ([#3032](#3032)) ([2499602](2499602)) * Fix default secondary roles after BCR 2024_07 ([#3040](#3040)) ([2ca465a](2ca465a)), closes [#3038](#3038) * Fix issues 2972 and 3007 ([#3020](#3020)) ([1772387](1772387)) * Fix known user resource issues ([#3013](#3013)) ([a5dfeac](a5dfeac)) * identifier issues ([#2998](#2998)) ([6fb76b7](6fb76b7)) * minor issues ([#3027](#3027)) ([467b06e](467b06e)), closes [#3015](#3015) [#2807](#2807) [#3025](#3025) * Nuke users ([#2971](#2971)) ([0d90cc9](0d90cc9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework user resource:
resource_helpers_create.go,resource_helpers_update.go, andresource_helpers_read.goparameterDefbetween user and schemaNext PRs:
checkBoolhelperresource_helpers_read.gosnowflake_user_password_policy_attachmentandsnowflake_user_public_keysIgnoreChangeToCurrentSnowflakeValueInShowand other suppressorsReferences: