Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add timeouts block to cortex #3004

Merged
merged 3 commits into from
Aug 21, 2024
Merged

feat: Add timeouts block to cortex #3004

merged 3 commits into from
Aug 21, 2024

Conversation

chris-codaio
Copy link
Contributor

These services can take well over 30 minutes to create and sometimes many hours. Add a timeout block so consumers can extend the default 30 minute timeout.

Patterned after the timeouts block on the existing tag_association object.

PTAL @sfc-gh-asawicki @sfc-gh-mloring

@chris-codaio
Add timeouts block to cortex
0520c80 
These services can take well over 30 minutes to create and sometimes many hours.  Add a timeout block so consumers can extend the default 30 minute timeout.
@sfc-gh-asawicki
Copy link
Collaborator

Hey @chris-codaio. Thanks for adding the timeouts. I have left just one comment about the changes in the generated file. Otherwise LGTM.

@chris-codaio
Copy link
Contributor Author

Hey @chris-codaio. Thanks for adding the timeouts. I have left just one comment about the changes in the generated file. Otherwise LGTM.

I believe I've addressed your comment. PTAL when you get a chance!
Do you know when this might hit the release channel so we can plan accordingly on our end?

@sfc-gh-asawicki sfc-gh-asawicki changed the title Add timeouts block to cortex feat: Add timeouts block to cortex Aug 21, 2024
@sfc-gh-asawicki sfc-gh-asawicki merged commit 34d764b into Snowflake-Labs:main Aug 21, 2024
2 checks passed
@sfc-gh-asawicki
Copy link
Collaborator

Hey @chris-codaio. Thanks again for the contribution. It will be a part of the next release (tomorrow or on Friday).

@snowflake-release-please snowflake-release-please bot mentioned this pull request Aug 20, 2024
Merged
@chris-codaio chris-codaio deleted the add-cortex-create-update-timeouts branch August 23, 2024 16:11
sfc-gh-jcieslak pushed a commit that referenced this pull request Sep 4, 2024
@snowflake-release-please
chore(main): release 0.95.0 (#2977)
cd1636c 
🤖 I have created a release *beep* *boop*
---


##
[0.95.0](v0.94.1...v0.95.0)
(2024-09-04)


### 🎉 **What's new:**

* Add change_tracking, row access policy and aggregation policy to views
([#2988](#2988))
([1f88bb1](1f88bb1))
* Add fully_qualified_name to all resources
([#2990](#2990))
([1b0462f](1b0462f))
* Add identifier parsers
([#2957](#2957))
([824ec52](824ec52))
* Add identifier with arguments
([#2979](#2979))
([00ae1c5](00ae1c5))
* Add timeouts block to cortex
([#3004](#3004))
([34d764b](34d764b))
* Add user parameters to resource
([#2968](#2968))
([f4ae380](f4ae380))
* Conclude user rework
([#3036](#3036))
([23e4625](23e4625))
* database role v1 readiness
([#3014](#3014))
([c4db255](c4db255))
* Identifier with arguments for procedure and external function
([#2987](#2987))
([f13cc5c](f13cc5c))
* Rework user resource
([#3026](#3026))
([bde2638](bde2638)),
closes
[#1572](#1572)
* Rework users datasource
([#3030](#3030))
([751239b](751239b)),
closes
[#2902](#2902)
* Upgrade view sdk
([#2969](#2969))
([ef2d50a](ef2d50a))
* View rework part 2
([#3021](#3021))
([e05377d](e05377d))
* View rework part 3
([#3023](#3023))
([195b41c](195b41c))


### 🔧 **Misc**

* Add annotation about fully_qualified_name and fix handling granteeName
([#3009](#3009))
([94e6345](94e6345))
* Apply identifier conventions
([#2996](#2996))
([5cbea84](5cbea84))
* apply identifier conventions to grants
([#3008](#3008))
([d7780ae](d7780ae))
* Clean collection utils
([#3028](#3028))
([426ddb1](426ddb1))
* Clean old assertions
([#3029](#3029))
([ad657eb](ad657eb))
* Conclude identifiers rework
([#3011](#3011))
([c1b53f3](c1b53f3))
* Improve user test and add manual test for user default database and
role
([#3035](#3035))
([6cb0b4e](6cb0b4e))
* Use new identifier with arguments in function, external function and
procedure grants
([#3002](#3002))
([5053f8b](5053f8b))
* User improvements
([#3034](#3034))
([65b64d7](65b64d7))


### 🐛 **Bug fixes:**

* database tests and introduce a new parameter
([#2981](#2981))
([3bae7f6](3bae7f6))
* Fix custom diffs for fields with diff supression
([#3032](#3032))
([2499602](2499602))
* Fix default secondary roles after BCR 2024_07
([#3040](#3040))
([2ca465a](2ca465a)),
closes
[#3038](#3038)
* Fix issues 2972 and 3007
([#3020](#3020))
([1772387](1772387))
* Fix known user resource issues
([#3013](#3013))
([a5dfeac](a5dfeac))
* identifier issues
([#2998](#2998))
([6fb76b7](6fb76b7))
* minor issues
([#3027](#3027))
([467b06e](467b06e)),
closes
[#3015](#3015)
[#2807](#2807)
[#3025](#3025)
* Nuke users
([#2971](#2971))
([0d90cc9](0d90cc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-codaio @sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak