Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip mandatory commitment when beefy authorities not changed #1215

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Skip mandatory commitment when beefy authorities not changed #1215

wants to merge 41 commits into from

Commits on Jan 31, 2024

  1. Permit non-consecutive increases in validator set 

    Changes the validator set successions to still be sequential, but non-consecutive.

For bridge security against collusion by validators, it's important that
these validators are still bonded, but the timing of the signature itself
is secondary.

As such, even if some validators have rotated out, this change permits
keeping the bridge alive so long as 2/3rds of the `currentValidatorSet`
are still bonded and sign the commitment.

Co-authored-by: bhargavbh <[email protected]>
Co-authored-by: Alistair Stewart <[email protected]>
    @Lederstrumpf @bhargavbh @AlistairStewart
    3 people committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a686dfa View commit details
    Browse the repository at this point in the history

  2. adjust submitInitial too 

    Co-authored-by: bhargavbh <[email protected]>
    @Lederstrumpf @bhargavbh
    Lederstrumpf and bhargavbh committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a223f97 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Improve filtering

    @vgeddes
    vgeddes committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ea2f146 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Skip mandatory commitment

    @yrong
    yrong committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ebb5794 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'Lederstrumpf/permit-nonconsecutive-incr… 

    …eases-in-validator-set' into ron/skip-mandatory-commitment-when-authorities-not-changed
    @yrong
    yrong committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0faba1f View commit details
    Browse the repository at this point in the history

  3. Fix updating with current beefy state

    @yrong
    yrong committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5eba01b View commit details
    Browse the repository at this point in the history

  4. Ignore submit when authorities not change

    @yrong
    yrong committed May 28, 2024
    Configuration menu
    Copy the full SHA
    482e8a2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Cleanup

    @yrong
    yrong committed May 29, 2024
    Configuration menu
    Copy the full SHA
    40f9592 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Improve BEEFY relayer

    @vgeddes
    vgeddes committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8853005 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Sync beefy commitment on demand

    @yrong
    yrong committed May 31, 2024
    Configuration menu
    Copy the full SHA
    629a478 View commit details
    Browse the repository at this point in the history

  2. Minor fix

    @yrong
    yrong committed May 31, 2024
    Configuration menu
    Copy the full SHA
    67c52e8 View commit details
    Browse the repository at this point in the history

  3. More comments

    @yrong
    yrong committed May 31, 2024
    Configuration menu
    Copy the full SHA
    dba8cfc View commit details
    Browse the repository at this point in the history

  4. More refactoring

    @yrong
    yrong committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a886879 View commit details
    Browse the repository at this point in the history

  5. review feedback

    @vgeddes
    vgeddes committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fd7db5b View commit details
    Browse the repository at this point in the history

  6. review feedback #2

    @vgeddes
    vgeddes committed May 31, 2024
    Configuration menu
    Copy the full SHA
    58d83bc View commit details
    Browse the repository at this point in the history

  7. unused code

    @vgeddes
    vgeddes committed May 31, 2024
    Configuration menu
    Copy the full SHA
    80b4dbd View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Fix for boundary update

    @yrong
    yrong committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c11ed7d View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Fix for skip mandatory commitment

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    10f38d4 View commit details
    Browse the repository at this point in the history

  2. Some refactoring

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    98e3e74 View commit details
    Browse the repository at this point in the history

  3. Fix ci breaking

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fc29329 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'vincent/beefy-relay-improvements' into ron/beefy-relay-… 

    …improvements
    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6efd6c1 View commit details
    Browse the repository at this point in the history

  5. Find for next beefy block

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    715ac5a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ron/beefy-relay-improvements' into ron/skip-mandatory-c… 

    …ommitment
    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7d06d62 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'ron/skip-mandatory-commitment' of https://github.com/Sn… 

    …owfork/snowbridge into ron/skip-mandatory-commitment
    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    16c5012 View commit details
    Browse the repository at this point in the history

  8. Improve log

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    913960e View commit details
    Browse the repository at this point in the history

  9. Remove check unrelated

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    edd9f21 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'ron/beefy-relay-improvements' into ron/skip-mandatory-c… 

    …ommitment
    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    47b0530 View commit details
    Browse the repository at this point in the history

  11. Check commitment in CurrentValidatorSetID

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    08c70f1 View commit details
    Browse the repository at this point in the history

  12. Sync beefy commitment on demand (#1217) 

    * Sync beefy commitment on demand

* Minor fix

* More comments

* More refactoring

* Fix for skip mandatory commitment

* Some refactoring

* Find for next beefy block

* Improve log

* Remove check unrelated
    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    95845a3 View commit details
    Browse the repository at this point in the history

  13. Resolve conflicts

    @yrong
    yrong committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    bb0c52f View commit details
    Browse the repository at this point in the history

  14. unused context parameter

    @vgeddes
    vgeddes committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6d26d04 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into vincent/beefy-relay-improvements

    @vgeddes
    vgeddes committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    39aac20 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'vincent/beefy-relay-improvements' into ron/skip-mandato… 

    …ry-commitment
    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ba37da4 View commit details
    Browse the repository at this point in the history

  2. Test happy path

    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3d8daa6 View commit details
    Browse the repository at this point in the history

  3. More tests

    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    47cceeb View commit details
    Browse the repository at this point in the history

  4. More tests

    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0f221e5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ron/skip-mandatory-commitment

    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ae9c1ad View commit details
    Browse the repository at this point in the history

  6. For rococo compatibility

    @yrong
    yrong committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    585619e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'main' into ron/skip-mandatory-commitment

    @yrong
    yrong committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4b80965 View commit details
    Browse the repository at this point in the history

  2. Revert changes

    @yrong
    yrong committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2b30202 View commit details
    Browse the repository at this point in the history

  3. Allow commitment in future

    @yrong
    yrong committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c99028d View commit details
    Browse the repository at this point in the history