Add new SomaScan version functionality #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new `getSomaScanVersion()` and `checkSomaScanVersion()` functions - reorganized docs to merge with `getAdatVersion()` - getAdatVersion()` now takes the full attributes as its input, rather than `x$Header.Meta` - updated documentation - fixes SomaLogic#83
- containing commonly used params in the package - `write_adat()`, `getAnalyteInfo()`, `getSomaScanVersion()`
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 73.88% 74.06% +0.17%
==========================================
Files 39 39
Lines 1455 1465 +10
==========================================
+ Hits 1075 1085 +10
Misses 380 380 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main changes
Now uses a
paramsdictionarywrite_adat(),getAnalyteInfo(),getSomaScanVersion()Added SomaScan version to S3 print method
Additional ADAT "get" helpers
getSomaScanVersion()andcheckSomaScanVersion()functionsgetAdatVersion()getSomaScanVersion()#83Major change (internal)
getAdatVersion()now takes the full attributes as its input, rather thanattr$Header.Meta