Perform eventlet monkey patching in the sensor wrapper #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
force-pushed
the
sensor_wrapper_eventlet_monkeypatching
branch
from
0abe928
to
c10b639
Compare
|
👍 |
Kami
added a commit
that referenced
this pull request
Jan 27, 2015
…eypatching Perform eventlet monkey patching in the sensor wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we explicitly perform it in the sensors, but with this change, we don't need to do this anymore.
Originally, the idea was not to perform it in the wrapper and the sensors who need it must explicitly opt-in (in general blocking is not an issue here since sensors run in a separate process).
And if this ever becomes a problem, we can also make it opt-in (or opt-out) via sensor metadata or via base-class.