Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistral Deprecation Game Plan #4762

Closed
22 of 25 tasks
arm4b opened this issue Aug 8, 2019 · 24 comments
Closed
22 of 25 tasks

Mistral Deprecation Game Plan #4762

arm4b opened this issue Aug 8, 2019 · 24 comments
Milestone

Comments

@arm4b
Copy link
Member

arm4b commented Aug 8, 2019

Mistral deprecation in favor of new workflow engine Orquesta was communicated for quite a long time.
StackStorm v3.2 will be latest version to ship Mistral with full removal in st2 v3.3 per Roadmap.

There is a helper Mistral -> Orquesta conversion tool available:
https://github.com/EncoreTechnologies/orquestaconvert
Special thanks @nmaludy an EncoreTechnologies for the tool

The Plan: https://github.com/orgs/StackStorm/projects/16

@m4dcoder feel free to adjust the task list to make sure we don't forget any other places with mistral occurrences.

@arm4b arm4b added this to the 3.3.0 milestone Aug 8, 2019
@Deepika-Kamalla
Copy link

So, would it be a valid assumption that PostgreSQL would also be removed from v3.3?

@arm4b
Copy link
Member Author

arm4b commented Oct 10, 2019

@Deepika-Kamalla That's correct.

@Deepika-Kamalla
Copy link

Deepika-Kamalla commented Oct 10, 2019

Thanks, Armab!! Is there any tentative timeline when v3.3 would be GA?

@arm4b
Copy link
Member Author

arm4b commented Oct 10, 2019

No timeline yet. This is something yet to be figured, considering recent LinuxFoundation transition.

@amanda11
Copy link
Contributor

I'll start looking at the one-line installer changes.

@winem
Copy link
Contributor

winem commented Aug 3, 2020

Just a quick note as I just noticed it while working on other PRs: We can also drop Postgres from the install docs as soon as Mistral is officially removed. Not sure if this is already clear and included in update docs.

@winem
Copy link
Contributor

winem commented Aug 12, 2020

I started to remove mistral from st2docs and started with the reference/ha.rst and referenced configuration sample (st2/conf/HA/st2.conf.sample & st2/conf/HA/nginx/st2.conf.blueprint.sample).

Who has access to edit the HA reference deployment image to remove PostgreSQL? https://docs.google.com/drawings/d/1X6u8BB9bnWkW8C81ERBvjIKRfo9mDos4XEKeDv6YiF0/edit

An update of the deployment overview is the only thing that's missing to be done with the ha.rst.

I'll proceed with the remaining reference sites tomorrow and provide a PR once I'm done.

I would suggest to create a MR per chapter so that we can share the work a bit. Otherwise I could also offer to take care of the whole docs but this probably takes some days until I'm completely done. Let me know if you have other ideas or prefer another approach.

@amanda11
Copy link
Contributor

@winem Sharing chapters sounds like a great approach. I don't know about the image updates, but if I get chance to start on some docs tomorrow - I'll let you know the chapter and I'll avoid the reference/... pages.

@blag
Copy link
Contributor

blag commented Aug 13, 2020

@winem I removed Mistral from both the HA deployment big picture and the deployment single box drawings. I did tweak the numbers, so you'll need to update the corresponding numbers where they appear in the documentation (I'm not sure where all they show up, or I would have done that myself).

Let me know if you can't view/export them and I'll export them for you (PNG or SVG?). And feel free to ping me if you need anything else removed or tweaked.

@amanda11
Copy link
Contributor

@winem I'll start on the install chapter - so far looks like all files in my PR will be in the install sub-directory except for upgrade-notes

@winem
Copy link
Contributor

winem commented Aug 13, 2020

@blag I can't access the files yet but requested the access permissions via Google. I guess you have a mail. I'll create a draft PR later today and start with the next chapter also this evening or latest tomorrow. Will let you know which one I choose next.

@winem
Copy link
Contributor

winem commented Aug 15, 2020

What is meant with Remove mistral from Deployments? I'm wondering if that's something where I can help.

@amanda11
Copy link
Contributor

@winem I believe it's all the different deployments, ie. its just a header for the checkboxes that are under it e.g. ansible etc. All are done except puppet, and I believe @nmaludy said he'd take care of that.

@blag
Copy link
Contributor

blag commented Aug 17, 2020

Here is the updated st2-deployment-big-picture:
st2-deployment-big-picture

And the updated deployment-single-box:
deployment-single-box

The Markdown to include them:

![st2-deployment-big-picture](https://user-images.githubusercontent.com/597113/90346098-fc7aeb00-dfda-11ea-95ad-12b95e1b17b8.png)
![deployment-single-box](https://user-images.githubusercontent.com/597113/90346101-00a70880-dfdb-11ea-9ad0-07752ad074ea.png)

But the docs are all written in RST, so you'll have to adapt it to that. I would suggest hotlinking to these images (eg: use these image URLs) rather than uploading them to GitHub a second time.

Let me know if you need anything else!

@arm4b
Copy link
Member Author

arm4b commented Aug 17, 2020

Nice one, thanks @blag!

@winem
Copy link
Contributor

winem commented Aug 18, 2020

Hi @blag, thanks for the updated diagrams!

Can you also update the st2-deployment-multi-node.png (source: https://docs.google.com/drawings/d/1_BJa9ZtBjFa1Dxx6cPiFlmpTS9AsNzkkvp_vuyVV3bw/edit)? That would be perfect and I would take care of the update in the docs then.

@winem
Copy link
Contributor

winem commented Aug 19, 2020

I updated the big-picture (see #1016) but could not find the single-box diagram anywhere in the docs. It would be great if a 2nd pair of eyes can confirm that I did not missed it and my grep-foo did not fail, too.

Now we need the st2-deployment-multi-node.png to be done with the diagrams.

@winem
Copy link
Contributor

winem commented Aug 22, 2020

I've identified another diagram that needs an update. The architecture_diagram.jpg which is also shown at https://docs.stackstorm.com/latest/overview.html still mentions mistral workflows, services and definitions. @blag do you have access to the sources?

@blag
Copy link
Contributor

blag commented Sep 3, 2020

I missed the multi-node deployment image. The (new) Google Drawing for that is here:
https://docs.google.com/drawings/d/11YAWFFMkEBw5VJGpMGNJCtT5IiiGsdrPJcH4jGaxeeo/edit

But here it is for your convenience:

StackStorm multi-node deployment without Mistral

@amanda11
Copy link
Contributor

amanda11 commented Sep 3, 2020

Thanks @blag . PR to include that diagram is here StackStorm/st2docs#1018. Just the architecture diagram remaining.

@blag
Copy link
Contributor

blag commented Sep 4, 2020

And here's the architecture diagram:

StackStorm Component Diagram

I'm in the process of trying to export this image to a more universal format (like SVG!), and/or to get the TSC a traditional OmniGraffle license for free or reduced cost.

@winem
Copy link
Contributor

winem commented Sep 5, 2020

Ok, I'll wait for an update before creating a PR. Is lucidchart an alternative? It's not really expensive, completely online and I have good experience with it. I'm not sure if everyone who needs / wants to change diagrams is a Mac user (as far as I saw Omnigraffle seems to be an iOS / MacOS only software).

arm4b added a commit to StackStorm/mistral that referenced this issue Sep 10, 2020
As part of the Mistral Deprecation game plan in st2 `v3.3.0`: StackStorm/st2#4762 add Deprecation warning to the repo readme.
@blag
Copy link
Contributor

blag commented Sep 15, 2020

#5023 includes the new Mistral architecture image.

@arm4b
Copy link
Member Author

arm4b commented Oct 1, 2020

I believe mistral is fully removed from the codebase, diagrams, docs, ci/cd updated, repos archived and this issue could be closed.
Thanks @amanda11 for leading this work and others for help! 🎉

@arm4b arm4b closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants