Skip to content

Commit

Permalink
add docker-for-desktop support (kubeflow#1954)
Browse files Browse the repository at this point in the history
Signed-off-by: Roberto Gandolfo Hashioka [email protected]
Signed-off-by: Roberto Gandolfo Hashioka <[email protected]>
  • Loading branch information
Roberto Gandolfo Hashioka authored and k8s-ci-robot committed Nov 26, 2018
1 parent 7ccc9a6 commit 9ac3974
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions scripts/kfctl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ createEnv() {
echo KUBEFLOW_PLATFORM=minikube >> ${ENV_FILE}
echo MOUNT_LOCAL=${MOUNT_LOCAL} >> ${ENV_FILE}
;;
docker-for-desktop)
echo KUBEFLOW_PLATFORM=docker-for-desktop >> ${ENV_FILE}
echo MOUNT_LOCAL=${MOUNT_LOCAL} >> ${ENV_FILE}
;;
ack)
echo KUBEFLOW_PLATFORM=ack >> ${ENV_FILE}
echo KUBEFLOW_DOCKER_REGISTRY=registry.aliyuncs.com >> ${ENV_FILE}
Expand Down Expand Up @@ -140,14 +144,14 @@ ksApply() {
ks apply default -c pipeline

# Reduce resource demands locally
if [ "${PLATFORM}" != "minikube" ]; then
if [ "${PLATFORM}" != "minikube" ] && [ "${PLATFORM}" != "docker-for-desktop" ]; then
ks apply default -c katib
fi

popd

set +x
if [ "${PLATFORM}" == "minikube" ]; then
if [ "${PLATFORM}" == "minikube" ] || [ "${PLATFORM}" == "docker-for-desktop" ]; then
if is_kubeflow_ready; then
mount_local_fs
setup_tunnels
Expand Down Expand Up @@ -315,7 +319,7 @@ main() {
gcpGenerateKsApp
fi

if [ "${PLATFORM}" == "minikube" ]; then
if [ "${PLATFORM}" == "minikube" ] || [ "${PLATFORM}" == "docker-for-desktop" ]; then
create_local_fs_mount_spec
if ${MOUNT_LOCAL}; then
ks param set jupyter disks "local-notebooks"
Expand Down

0 comments on commit 9ac3974

Please sign in to comment.