-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-for-desktop platform #1954
Add docker-for-desktop platform #1954
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Hi @rogaha. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5b0add8
to
c975d32
Compare
/ok-to-test Looks like this PR needs to be sync'd. |
Can you also follow up with a PR adding instructions on kubeflow/website? |
/assign @r2d4 |
/lgtm Needs a rebase. And you'll need to sign the CLA. Thanks! |
c975d32
to
63fe69d
Compare
63fe69d
to
19a0202
Compare
PR rebased |
@r2d4 PTAL |
Signed-off-by: Roberto Gandolfo Hashioka [email protected] Signed-off-by: Roberto Gandolfo Hashioka <[email protected]>
19a0202
to
b550391
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/assign @lluunn |
@texasmichelle can you help us with this PR? I've rebased it twice already. :) |
/ok-to-test |
happy to see some d-for-d action here :) Thanks @rogaha! |
@r2d4 pls re-approve |
Thanks @texasmichelle. |
the |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r2d4, texasmichelle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Roberto Gandolfo Hashioka [email protected] Signed-off-by: Roberto Gandolfo Hashioka <[email protected]>
minikube
, nothing special.Signed-off-by: Roberto Gandolfo Hashioka [email protected]
#TODO
-- Add documentation explaining how to installDocker for Desktop
in the first place.closes #218
This change is