Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-for-desktop platform #1954

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

rogaha
Copy link
Contributor

@rogaha rogaha commented Nov 15, 2018

  • Steps required are similar to the ones from minikube, nothing special.

Signed-off-by: Roberto Gandolfo Hashioka [email protected]

screenshot of iterm2 11-14-18 5-44-07 pm

#TODO -- Add documentation explaining how to install Docker for Desktop in the first place.

closes #218


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Contributor

Hi @rogaha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Nov 19, 2018

/ok-to-test

Looks like this PR needs to be sync'd.

@jlewi
Copy link
Contributor

jlewi commented Nov 19, 2018

Can you also follow up with a PR adding instructions on kubeflow/website?

@jlewi
Copy link
Contributor

jlewi commented Nov 19, 2018

/assign @r2d4

@r2d4
Copy link
Member

r2d4 commented Nov 19, 2018

/lgtm

Needs a rebase. And you'll need to sign the CLA. Thanks!

@rogaha
Copy link
Contributor Author

rogaha commented Nov 20, 2018

PR rebased

@rogaha
Copy link
Contributor Author

rogaha commented Nov 20, 2018

@r2d4 PTAL

Signed-off-by: Roberto Gandolfo Hashioka [email protected]
Signed-off-by: Roberto Gandolfo Hashioka <[email protected]>
@rogaha rogaha force-pushed the add_docker_for_desktop_platform branch from 19a0202 to b550391 Compare November 20, 2018 23:23
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot removed the cla: no label Nov 20, 2018
Copy link
Member

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@rogaha
Copy link
Contributor Author

rogaha commented Nov 21, 2018

/assign @lluunn

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 21, 2018
@rogaha
Copy link
Contributor Author

rogaha commented Nov 21, 2018

@texasmichelle can you help us with this PR? I've rebased it twice already. :)

@texasmichelle
Copy link
Member

/ok-to-test
/lgtm
/approve

@texasmichelle
Copy link
Member

happy to see some d-for-d action here :) Thanks @rogaha!

@texasmichelle
Copy link
Member

@r2d4 pls re-approve

@rogaha
Copy link
Contributor Author

rogaha commented Nov 25, 2018

Thanks @texasmichelle.

@rogaha
Copy link
Contributor Author

rogaha commented Nov 26, 2018

the bot says it's has been approved by @r2d4 and @texasmichelle. How many LGTMs do we need?

@r2d4
Copy link
Member

r2d4 commented Nov 26, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r2d4, texasmichelle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 63141ef into kubeflow:master Nov 26, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Signed-off-by: Roberto Gandolfo Hashioka [email protected]
Signed-off-by: Roberto Gandolfo Hashioka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate using Docker to run Kubernetes and Kubeflow locally
7 participants