741 default instance-wide optout message #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, new api query and resolver
…api/organization and out of view
shakalee14
reviewed
Sep 10, 2018
src/containers/Settings.jsx
Outdated
| @@ -1,5 +1,6 @@ | |||
| import PropTypes from 'prop-types' | |||
| import React from 'react' | |||
| import TextField from 'material-ui/TextField' | |||
There was a problem hiding this comment.
Can we remove this unused import?
shakalee14
reviewed
Sep 10, 2018
|
|
||
| <Form.Field | ||
| label='Default Opt-Out Message' | ||
| name='optOutMessage' |
There was a problem hiding this comment.
can we add the prop fullWidth here so the user can see the full message (versus having to scroll within the form field) ?
shakalee14
reviewed
Sep 10, 2018
shakalee14
approved these changes
Sep 12, 2018
shakalee14
added
the
S-ready for stage-main (qa)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new place to edit org-specific optout message in org settings, and if set, it'll override both the env var instance-wide setting OPT_OUT_MESSAGE and also the hard coded default "I'm opting you out of texts immediately. Have a great day." Test this by going into your name (in top right) -> your org -> settings and then editing the "Default opt-out message" setting. #741