Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage main #901

Merged
merged 159 commits into from
Sep 17, 2018
Merged

Stage main #901

merged 159 commits into from
Sep 17, 2018

Conversation

shakalee14
Copy link
Contributor

@shakalee14 shakalee14 commented Sep 12, 2018

Caching/Optimization Branches:
#889, #876, #850, #833

Caching/Feature Integrated Branches:
#900, #898, #891

New Features:
#882 & #911

Bug Fixes
#905, #868, #828, #817, #880

Testing:
#881

Migrations:
#900 adds a migration to the campaign table :

  • new columns : override_organization_texting_hours, texting_hours_enforced, texting_hours_start, texting_hours_end

cp4r3z and others added 30 commits July 9, 2018 16:40
@shakalee14 shakalee14 added the S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance label Sep 12, 2018
@azuzunaga
Copy link
Collaborator

@shakalee14 tl;dr:

Pass Fail
1, 2, 3 4

I did QA following these instructions:

  1. New texting hours per campaign withcaching #900 Texting Hours Per Campaign:
    With an organization with texting hours enforcement set (in /settings), create a campaign and upload a csv without zip codes. Assign texts and at texting hours panel, set texting hours that conflict with the organizational texting hours. Start the campaign and switch to a texter. Ensure that texting is dis/abled based on texting hours set in the campaign.

  2. added sorting to post-scaling query to load canned responses from db #898 Canned Responses Sorting:
    Create a campaign with several canned responses. When you create a campaign, and switch to texter, send texts and receive replies. When getting into the texter reply view, verify that canned responses are sorted by title (asc)

  3. Bug : Max Contacts on Dynamic Assignment Does Not Work #828 Setting 0 for Max Contacts for Dynamic Assignment
    Create a campaign and toggle dynamic assignment. Add texters (ones you have access to) and set one texter 's MAX to 0. Switch to texter view where you set 0 and ensure that send button is greyed for that texter. Return to admin view, remove the 0 and save for the texter. Switch back and check if texting has been enabled again for that texter.

  4. 741 default instance-wide optout message #882 Setting Opt Out Message for Org in Admin Panel
    As an admin, visit the settings panel. Update the opt out message. And in an active campaign, verify that opt out message matches message set in the admin panel.

Only part 4 failed. I wasn't able to save a custom opt out message in the admin settings panel.

@shakalee14
Copy link
Contributor Author

shakalee14 commented Sep 13, 2018

Hey @azuzunaga

For Part 4: It looks like it is working - for that organization, you are an ADMIN and you need to be an OWNER in order to change organizational settings. In the console you probably received a You are not authorized to access that resource error.

we also added a call to invalidate the org cache when the opt out message is updated.

@shakalee14 shakalee14 added the S-testing in production Status (ADMINS ONLY): PR label for testing in production (next step: merge) label Sep 14, 2018
Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-testing in production Status (ADMINS ONLY): PR label for testing in production (next step: merge) S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants