Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Campaign page related fixes #905

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Campaign page related fixes #905

merged 2 commits into from
Sep 17, 2018

Conversation

shakalee14
Copy link
Contributor

This PR fixes 2 things:

  1. A bug introduced by https://github.com/MoveOnOrg/Spoke/pull/816 which breaks the ability to view the message review panel because of this error : "Cannot read property 'listSize' of undefined"
  2. A request to change the default page size to be 50 (vs 25) by @ErikKirkstein

@shakalee14 shakalee14 added the C-bug Type: Bug label Sep 12, 2018
mathemagica
mathemagica approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@mathemagica mathemagica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shakalee14 shakalee14 mentioned this pull request Sep 13, 2018
Merged
@shakalee14 shakalee14 merged commit 8cdcc9b into main Sep 17, 2018
@schuyler1d schuyler1d deleted the campaign-page-related-fixes branch March 26, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathemagica mathemagica mathemagica approved these changes

@azuzunaga azuzunaga azuzunaga approved these changes

Assignees
No one assigned
Labels
C-bug Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shakalee14 @mathemagica @azuzunaga