-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Login With Steam #132
Add: Login With Steam #132
Conversation
c45cf90
to
14fe86f
Compare
I created an Issue (#133) corresponding to the PR, I forgot to add an example for the Steam Auth Ticket For Web API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few bits of nitpicking, but overall really nice, thank you!
I feel like this and the actual integration (with the code you have in the docs) should be it's own |
…with method _on_login)
8e65a28
to
6307292
Compare
docs/user/Logins/login-steam.md
Outdated
Before beginning, you should have: | ||
- A PlayFab Title | ||
- A Steam App Id | ||
- A Steam Publish Web API Key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: change Publish
to Publisher
docs/user/Logins/login-steam.md
Outdated
|
||
1. Click on the "Install Steam" | ||
1. Enter your Steam Application ID | ||
2. Enter your Steam Web API Key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve clarity: Change Steam Web API Key
to Steam Publisher Web API Key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
Before beginning, you should have: | ||
- A PlayFab Title | ||
- A Steam App Id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheDedemon Can it somehow be tested without having your own AppID, as suggested in the docs on how to integrate with GodotSteam? I don't think so, because you need the Steam Web API Key in the Steam add-on in PlayFab, right?
|
||
## :warning: Troubleshooting | ||
|
||
They are many possibles errors, the most commons are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
They are many possibles errors, the most commons are:
perhaps use:
They are many possible errors, but the most common ones are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
Hi, the feature can be tested on my branch tests/login_with_steam. I didn't put it with the feature to avoid importing external extension in the main branch.