Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Login With Steam #132

Merged
merged 22 commits into from
Jun 1, 2024

Conversation

TheDedemon
Copy link
Contributor

Hi, the feature can be tested on my branch tests/login_with_steam. I didn't put it with the feature to avoid importing external extension in the main branch.

@Structed Structed self-requested a review December 14, 2023 21:27
@TheDedemon TheDedemon closed this Dec 15, 2023
@TheDedemon TheDedemon deleted the features/login_with_steam branch December 15, 2023 09:34
@TheDedemon TheDedemon restored the features/login_with_steam branch December 15, 2023 09:41
@Structed Structed reopened this Dec 15, 2023
@TheDedemon
Copy link
Contributor Author

TheDedemon commented Dec 15, 2023

I created an Issue (#133) corresponding to the PR, I forgot to add an example for the Steam Auth Ticket For Web API.

Copy link
Owner

@Structed Structed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few bits of nitpicking, but overall really nice, thank you!

addons/godot-playfab/PlayFab.gd Outdated Show resolved Hide resolved
addons/godot-playfab/Models/LoginWithSteamRequest.gd Outdated Show resolved Hide resolved
addons/godot-playfab/Models/LoginWithSteamRequest.gd Outdated Show resolved Hide resolved
docs/user/Logins/login-steam.md Outdated Show resolved Hide resolved
docs/user/Logins/login-steam.md Outdated Show resolved Hide resolved
docs/user/Logins/login-steam.md Outdated Show resolved Hide resolved
@Structed
Copy link
Owner

I feel like this and the actual integration (with the code you have in the docs) should be it's own godot-playfab-steam addon. What are your thoughts on this, @TheDedemon?

@Structed Structed self-requested a review June 1, 2024 17:19
Before beginning, you should have:
- A PlayFab Title
- A Steam App Id
- A Steam Publish Web API Key
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: change Publish to Publisher


1. Click on the "Install Steam"
1. Enter your Steam Application ID
2. Enter your Steam Web API Key
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve clarity: Change Steam Web API Key to Steam Publisher Web API Key

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


Before beginning, you should have:
- A PlayFab Title
- A Steam App Id
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheDedemon Can it somehow be tested without having your own AppID, as suggested in the docs on how to integrate with GodotSteam? I don't think so, because you need the Steam Web API Key in the Steam add-on in PlayFab, right?


## :warning: Troubleshooting

They are many possibles errors, the most commons are:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of

They are many possibles errors, the most commons are:

perhaps use:

They are many possible errors, but the most common ones are:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@Structed Structed merged commit 29bd210 into Structed:develop Jun 1, 2024
2 checks passed
@Structed Structed mentioned this pull request Jun 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants