This repository has been archived by the owner on Feb 5, 2021. It is now read-only.
systemd: fix missing params in "containers.**" #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @beyondbill |
frankreno
approved these changes
Jan 31, 2019
|
Thanks! Subconsciously knew to look for this since I had a distant memory of #84. Will definitely come back and think about how to converge these configs or add more tests. |
|
If you have a sec to push out a new image I'd appreciate it, we'd like to try rolling this out later today. IMO #108 qualifies as a patch too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that after setting
KUBERNETES_META_REDUCEwe weren't seeing any effect. I tracked it down to the fact that we're using systemd as a source and there was some divergence between the configuration forfileandsystemd.For the future I'd like to do a bit of refactoring and pull out shared conf from the two sources to help avoid drift but for now I just wanted to get the problem fixed.