Skip to content

Commit

Permalink
Generate builds with RelWithDebInfo instead of Release (#2963)
Browse files Browse the repository at this point in the history
The resulting Windows builds should now be able to generate meaningful stacktraces.
Fixes #2945
  • Loading branch information
Vankata453 authored Jun 8, 2024
1 parent ec06d2e commit 7302e4b
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
matrix:
# TODO: Add the OpenBSD, NetBSD and Solaris VMs whenever possible
vm_os: [freebsd]
build_type: [Debug, Release]
build_type: [Debug, RelWithDebInfo]
# FreeBSD does not have glbinding
# glbiactions/checkout@v4

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gnulinux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ jobs:
arch: [32, 64]
os: [ubuntu-20.04]
compiler: [gcc, clang]
build_type: [Debug, Release]
build_type: [Debug, RelWithDebInfo]
glbinding: [ON, OFF]
exclude:
- arch: 32
glbinding: ON
include:
- os: ubuntu-20.04
build_type: Release
build_type: RelWithDebInfo
compiler: gcc
arch: 64
glbinding: OFF
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ jobs:
fail-fast: false
matrix:
os: [macos-12]
build_type: [Debug, Release]
build_type: [Debug, RelWithDebInfo]
glbinding: [ON, OFF]
include:
- os: macos-12
build_type: Release
build_type: RelWithDebInfo
glbinding: OFF
release: ON

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ubuntu-touch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false
matrix:
build_type: [Debug, Release]
build_type: [Debug, RelWithDebInfo]
arch: [amd64, arm64, armhf]
# glbinding is missing as it isn't available on Ubuntu 16.04
opengl: [glew, sdl]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false
matrix:
build_type: ["Release", "Debug"]
build_type: ["RelWithDebInfo", "Debug"]

runs-on: ubuntu-latest
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ jobs:
fail-fast: false
matrix:
arch: [x64, x86]
build_type: [Debug, Release]
build_type: [Debug, RelWithDebInfo]
glbinding: [OFF] # [ON, OFF] # FIXME: Fix Windows glbinding builds
include:
- build_type: Release
- build_type: RelWithDebInfo
arch: x64
glbinding: OFF
release: ON
- build_type: Release
- build_type: RelWithDebInfo
arch: x86
glbinding: OFF
release: ON
Expand Down

0 comments on commit 7302e4b

Please sign in to comment.