Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate builds with RelWithDebInfo instead of Release #2963

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Vankata453
Copy link
Member

@Vankata453 Vankata453 commented Jun 1, 2024

The resulting Windows builds should now be able to generate meaningful stacktraces.

Fixes #2945.

@mrkubax10 mrkubax10 added type:patch status:needs-review Work needs to be reviewed by other people category:tests labels Jun 3, 2024
@Rusty-Box Rusty-Box merged commit 7302e4b into master Jun 8, 2024
32 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jun 15, 2024
@mrkubax10 mrkubax10 deleted the relwithdebinfo branch June 15, 2024 10:53
Semphriss pushed a commit to Semphriss/supertux that referenced this pull request Aug 9, 2024
…uperTux#2963)"

This reverts commit 7302e4b.

RelWithDebInfo include debug data separately from the executable, which needs
a debugger to be interpreted properly. The debug data does not affect stack
traces generated by the program itself, but increases the executable by more
than 100Mb, which is wasted if the user does not intent to run the exectuable
inside a debugger.
tobbi pushed a commit that referenced this pull request Aug 18, 2024
…2963)" (#3040)

This reverts commit 7302e4b.

RelWithDebInfo include debug data separately from the executable, which needs
a debugger to be interpreted properly. The debug data does not affect stack
traces generated by the program itself, but increases the executable by more
than 100Mb, which is wasted if the user does not intent to run the exectuable
inside a debugger.

Co-authored-by: Semphris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate release builds as RelWithDebInfo
4 participants