-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scared Gold Bomb #2559
Merged
Merged
Scared Gold Bomb #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rusty-Box
added
involves:functionality
status:in-progress
Progress has been done, but more is intended be done
type:feature
category:code
category:design
labels
Jul 25, 2023
This comment has been minimized.
This comment has been minimized.
How did you get the Sprites for this? |
@Linusintro He drew them. |
* Gold Bomb now flees from Tux and any kind of Bomb about to explode
Rusty-Box
added
status:needs-review
Work needs to be reviewed by other people
and removed
status:in-progress
Progress has been done, but more is intended be done
labels
Aug 1, 2023
tobbi
reviewed
Aug 1, 2023
mrkubax10
reviewed
Aug 2, 2023
Vankata453
reviewed
Aug 3, 2023
* gold bomb goes faster when tux comes close * Go opposite direction when close to bomb * Fix turning around * gold bomb hop and turn away * A bunch of features: - Become cornered - Hop - Flee when player, haywire or bomb * New animations impl * bugfix * Fixed flappy bird bug * Change max drop height and push badguy out of the way! * add default case * change i to size_t * Ok wtf im using clang now. * Initializer list moment * Remove normal walkspeed easing and fall off edge if safe * oops * style guide [ci skip] * SAFE_DIST > REALIZE_DIST * Fix normal walking off edge * Code organization * remove debug drawing * Goldbomb react to other goldbomb and when squished doesnt turn * Gold bomb turn around when tux catches up * Prevent fleeing when gold bomb cant see * Change return to break inside switch case for consistency [ci skip] * Revert "Change return to break inside switch case for consistency [ci skip]" This reverts commit 1543135. * Gold bomb react to all things when seen * Push haywire * Fix weird animation when exiting safe dist when cornered by pit * Better debug drawing for distances * Fix walk in place when in safe dist after realizing * Fix weird behaviour when frozen * Minor tweaking and stylistic changes
Vankata453
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the comments from my previous review are left unresolved.
i noticed that. im gonna tell rusty to fix it rq |
tobbi
requested changes
Aug 24, 2023
mrkubax10
approved these changes
Aug 28, 2023
Vankata453
reviewed
Aug 30, 2023
* gold bomb goes faster when tux comes close * Go opposite direction when close to bomb * Fix turning around * gold bomb hop and turn away * A bunch of features: - Become cornered - Hop - Flee when player, haywire or bomb * New animations impl * bugfix * Fixed flappy bird bug * Change max drop height and push badguy out of the way! * add default case * change i to size_t * Ok wtf im using clang now. * Initializer list moment * Remove normal walkspeed easing and fall off edge if safe * oops * style guide [ci skip] * SAFE_DIST > REALIZE_DIST * Fix normal walking off edge * Code organization * remove debug drawing * Goldbomb react to other goldbomb and when squished doesnt turn * Gold bomb turn around when tux catches up * Prevent fleeing when gold bomb cant see * Change return to break inside switch case for consistency [ci skip] * Revert "Change return to break inside switch case for consistency [ci skip]" This reverts commit 1543135. * Gold bomb react to all things when seen * Push haywire * Fix weird animation when exiting safe dist when cornered by pit * Better debug drawing for distances * Fix walk in place when in safe dist after realizing * Fix weird behaviour when frozen * Minor tweaking and stylistic changes * Code documentation and minor fixes
tobbi
approved these changes
Sep 2, 2023
Vankata453
approved these changes
Sep 2, 2023
Vankata453
removed
the
status:needs-review
Work needs to be reviewed by other people
label
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gold Bomb will panic when Tux gets too close or any type of bomb is about to explode nearby.
They will run away for as long as Tux and/or a triggered bomb is in close range. If they reach a bottomless pit they "freeze" quivering in fear for as long as the "threat" is nearby (if there is safe ground they will drop down). When the area is all-clear, after a couple seconds, they will slowly resume their original behavior again.
This is a proof-of-concept made through the use of scripting and a ScriptedObject:
gold_bomb_scared.mp4