Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 6 #329

Closed
wants to merge 2 commits into from
Closed

Add support for Symfony 6 #329

wants to merge 2 commits into from

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Sep 21, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner September 21, 2021 22:10
@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch 3 times, most recently from 09e314b to cffff92 Compare September 21, 2021 22:46
@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from cffff92 to a6668b6 Compare November 5, 2021 15:58
@loic425
Copy link
Member Author

loic425 commented Nov 5, 2021 •
edited
Loading

@lchrusciel we need to merge this before #298

@loic425 loic425 mentioned this pull request Nov 5, 2021
Closed
@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch 3 times, most recently from 21a4ba4 to 04408ff Compare November 9, 2021 07:52
@Zales0123
Copy link
Member

@loic425 rebase needed, it would be wonderful to have it merge soon :)

@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from 225f483 to 987afcb Compare December 20, 2021 13:09
@loic425
Copy link
Member Author

loic425 commented Dec 20, 2021

@loic425 rebase needed, it would be wonderful to have it merge soon :)

done :)

@loic425
Copy link
Member Author

loic425 commented Dec 20, 2021

We need this PR to be merged before

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc. labels Dec 20, 2021
@Zales0123 Zales0123 force-pushed the feature/add-support-for-symfony-6 branch from 987afcb to 8347300 Compare December 20, 2021 16:37
@Zales0123
Copy link
Member

Waiting for winzou/StateMachineBundle#64

@Zales0123 Zales0123 mentioned this pull request Jan 10, 2022
Merged
lchrusciel added a commit that referenced this pull request Jan 12, 2022
@lchrusciel
bug #353 Require symfony/routing and symfony/http-foundation 4.4 and …
9829c76 
…5.4 (Zales0123)

This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

This bundle will still [not support Symfony 6](#329) before the next minor release, so we should make it explicit it does not work with those two symfony 6 components (`Sylius\Bundle\ResourceBundle\Controller\Parameters` declaration incompatibility and `Symfony\Component\Routing\RouteCollectionBuilder` class inexistence) 🖖 

Commits
-------

af5f456 Conflict with symfony/routing and symfony/http-foundation 6.0
@MrSrsen
Copy link
Contributor

MrSrsen commented Mar 4, 2022 •
edited
Loading

Hello. Issue winzou/StateMachineBundle#64 was resolved and I was wondering when this issue could move forward.

Is there anything that I could do to help Symfony 6 support? I would like to use SyliusResourceBundle in my project but I am waiting for this issue to be resolved because I want to use Symfony 6.

@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from 8f05133 to c6b1bfb Compare March 5, 2022 08:11
@loic425
Copy link
Member Author

loic425 commented Mar 5, 2022

Hello. Issue winzou/StateMachineBundle#64 was resolved and I was wondering when this issue could move forward.

Is there anything that I could do to help Symfony 6 support? I would like to use SyliusResourceBundle in my project but I am waiting for this issue to be resolved because I want to use Symfony 6.

Our main blocker for Sylius package is the phpspec usage. We plan to fork this package. Symfony 6 support is the next step after releasing the next stable release of this bundle.

@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from 9ab21a6 to 92e9e55 Compare March 16, 2022 08:39
@loic425 loic425 changed the base branch from master to 1.8 March 16, 2022 08:41
@loic425 loic425 closed this Mar 16, 2022
@loic425 loic425 reopened this Mar 16, 2022
@loic425 loic425 changed the base branch from 1.8 to master March 16, 2022 08:52
@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from 92e9e55 to cd18fa4 Compare March 16, 2022 08:58
@loic425 loic425 force-pushed the feature/add-support-for-symfony-6 branch from 011c3f2 to 3a3f213 Compare March 16, 2022 12:24
@loic425 loic425 changed the base branch from master to 1.8 March 16, 2022 12:24
@loic425 loic425 closed this Mar 16, 2022
@loic425 loic425 reopened this Mar 16, 2022
@loic425
Copy link
Member Author

loic425 commented Mar 30, 2022

Closed in favour of #396

@loic425 loic425 closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @Zales0123 @MrSrsen