Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require symfony/routing and symfony/http-foundation 4.4 and 5.4 #353

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

This bundle will still not support Symfony 6 before the next minor release, so we should make it explicit it does not work with those two symfony 6 components (Sylius\Bundle\ResourceBundle\Controller\Parameters declaration incompatibility and Symfony\Component\Routing\RouteCollectionBuilder class inexistence) 🖖

@Zales0123 Zales0123 added Bug Confirmed bugs or bugfixes. Maintenance Configurations, READMEs, releases, etc. labels Jan 10, 2022
@Zales0123 Zales0123 requested a review from a team as a code owner January 10, 2022 17:37
@loic425
Copy link
Member

loic425 commented Jan 11, 2022

I am not conviced to add it on conflict part. I think it's better to add them on requirements instead cause there are not optional requirements.

@Zales0123
Copy link
Member Author

@loic425 agreed 👍

@Zales0123 Zales0123 changed the title Conflict with symfony/routing and symfony/http-foundation 6.0 Require with symfony/routing and symfony/http-foundation 4.4 and 5.4 Jan 12, 2022
@Zales0123 Zales0123 changed the title Require with symfony/routing and symfony/http-foundation 4.4 and 5.4 Require symfony/routing and symfony/http-foundation 4.4 and 5.4 Jan 12, 2022
@lchrusciel lchrusciel merged commit 9829c76 into Sylius:master Jan 12, 2022
@lchrusciel
Copy link
Member

Thanks, Mateusz! 🎉

@Zales0123 Zales0123 deleted the conflict-with-symfony-6 branch January 12, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants