-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gameboy memory callback values #3904
base: master
Are you sure you want to change the base?
Add gameboy memory callback values #3904
Conversation
merged master into branch
bsnes build broke when rewind.c was removed because it defined the GB_rewind_reset, which was being linked in despite being no longer present. -DGB_DISABLE_REWIND turns off this link.
Fixed bsnes build
…om/roydmerkel/BizHawk into add-gameboy-memory-callback-values
…moved bank registers for sameboy to another file.
Some immediate issues I'm seeing.
|
on 1: yeah ,that's an oversight on my end, looks like sameboy change has already been merged, but I haven't updated the submodule path, I'll submit a change for that. For Gambette, it's still sitting in PR awaiting approval. |
…om/roydmerkel/BizHawk into add-gameboy-memory-callback-values
…ginally split off for speed reasons and because bsnes wasn't updating correctly when in registers, however, this looks unneccessary by testing.)
@CasualPokePlayer , addressed 1-4, I am tempted to revert libsnes changes as well as memory and execution breakpoints cause exceptions in libsnes for "SGB System Bus", and other domains don't seem to do anything. I'll probably do this then ping you in channel in Discord for re-review. But let me know if there's anything in my libsnes changes that you think would be useful to keep, otherwise, I'll probably revert the libsnes changes. |
… upstream (rebuilt gambette just in case.)
master --> add-gameboy-memory-callbacks
…execute callbacks for GameBoy
ok, rolled back libsnes changes as callbacks aren't supported on supergameboy memory in libsnes or bsnes, so the change was pointless, so I went ahead and rolled it back as it was one of your action items. |
@@ -108,7 +108,7 @@ public virtual void BulkPeekByte(Range<long> addresses, byte[] values) | |||
if (addresses is null) throw new ArgumentNullException(paramName: nameof(addresses)); | |||
if (values is null) throw new ArgumentNullException(paramName: nameof(values)); | |||
|
|||
if ((long) addresses.Count() != values.Length) | |||
if ((long) addresses.Count() > values.Length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? And is it part of the BANK register changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having issues with GBHawk requiring memory mapped buffer to match a 0x10000 size, so it was excepting incorrectly. It is unrelated to banking code, I'll revert that part and fix separately as part of a separate change.
Check if completed: